Invalidate is not behaving as expected

[AlaricBaraou]

Invalidate is not behaving as expected

[AlaricBaraou]

Can I do anything to help this one get merged ?

Like a demo or analysis on the impact on the eco-system etc

Let me know!

[AlaricBaraou]

Here is a demo using invalidate and Drei Orbitcontrols that perfectly showcase the difference.
When using the controls it request a render. Same when clicking the cube.
At the top of the demo I display the current number of frames queued in the root state.
We can see that the new version never goes over 1 and therefore never call unnecessary renders.

New version using the build from the linked PR
https://codesandbox.io/p/sandbox/basic-demo-forked-92gy2c?file=%2Fsrc%2FApp.js
Old version ( you can see how the frames stack up to 60 )
https://codesandbox.io/p/sandbox/invalidate-fix-forked-7sqggj?file=%2Fsrc%2FApp.js%3A43%2C28

I believe the majority of the ecosystem that use invalidate will keep working fine as long as they were already calling invalidate correctly.

[CodyJasonBennett]

Out since v8.16.1. This was the intended behavior, so I'm considering it a bugfix.

[CodyJasonBennett]

Implemented in #3185.

[AlaricBaraou]

Sorry the PR I linked previously (#3187) wasn't about this issue, it was a relatively unrelated issue and duplicate of my previous PR (#3185).
That PR was just about fixing how the parameter was passed but doesn't fix anything here.

This is the PR I intended to do and that would fix this issue.
#3197

edit: I updated the initial issue description to link to the correct PR