Giter Site home page Giter Site logo

Comments (5)

bbohlender avatar bbohlender commented on June 29, 2024

hmmm, thanks for the PR. I am not a fan of seperating json and png. I'd actually rather preferred it if the image was base64 encoded into the json. I know that this would require some build time tooling, but imo it would be the much cleaner solution with a better DX. What do you think?

from uikit.

Ledzz avatar Ledzz commented on June 29, 2024

Sounds reasonable. I'll try to do it on monday. I believe we still need some fix to make it work? I'll redo my PR.

from uikit.

bbohlender avatar bbohlender commented on June 29, 2024

if we use data urls it should not require any change, but you'd have to test it :)
https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URLs

if you come up with a process / tool to move the image into the json, it would be awesome if you could document that in the uikit docs :)

from uikit.

Ledzz avatar Ledzz commented on June 29, 2024

@bbohlender you're right, it works. I just thought that there will be some url composing logic that interferes using data urls. Made a PR with a sample script to do it: #56

from uikit.

bbohlender avatar bbohlender commented on June 29, 2024

@Ledzz thanks for the PR, script looks very nice. Eventually, I want the font file generation to be integrated into the pmndrs/uikit CLI, where I would also inline the texture by default :)

from uikit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.