Comments (5)
hmmm, thanks for the PR. I am not a fan of seperating json and png. I'd actually rather preferred it if the image was base64 encoded into the json. I know that this would require some build time tooling, but imo it would be the much cleaner solution with a better DX. What do you think?
from uikit.
Sounds reasonable. I'll try to do it on monday. I believe we still need some fix to make it work? I'll redo my PR.
from uikit.
if we use data urls it should not require any change, but you'd have to test it :)
https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URLs
if you come up with a process / tool to move the image into the json, it would be awesome if you could document that in the uikit docs :)
from uikit.
@bbohlender you're right, it works. I just thought that there will be some url composing logic that interferes using data urls. Made a PR with a sample script to do it: #56
from uikit.
@Ledzz thanks for the PR, script looks very nice. Eventually, I want the font file generation to be integrated into the pmndrs/uikit CLI, where I would also inline the texture by default :)
from uikit.
Related Issues (20)
- Relative paths on font family provider HOT 2
- Xr controller as input HOT 6
- fontSize percentage
- Yoga fails in StrictMode when manually rendering canvas HOT 4
- 'Root' cannot be used as a JSX component. HOT 2
- caret doesn't show until with focus()
- percentage support for transform properties HOT 1
- expose ref.current.getStyle and add default for ComponentInternals
- TypeScript: Missing `children` on ContainerProperties, and other issues. HOT 3
- Cannot install components via CLI HOT 2
- expose control over the three.js side property to render the back side of elements HOT 1
- Retained mode UI example HOT 3
- Render special characters and emojis HOT 1
- SVGs rendering wrong HOT 1
- Fix importing from `./theme.js` to be from `./theme` in generated code HOT 1
- Z-Index issue HOT 1
- Visibility hidden not working for children HOT 1
- double click to select word in input
- [Docs] "Vanilla Three.js" tab disappears when other tabs selected HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uikit.