Pinch gestures trigger onWheel

[pmndrs]

Pinch gestures trigger onWheel

[andreas-eberle]

No worries! Thanks for the support and super fast help! It works now 👍

[dbismut]

Right, I think see where this comes from. Can you confirm you’re using a trackpad with Chrome or if using Safari, are your binding the component (ie not using domTarget)? Essentially when you pinch to zoom on a trackpad browsers might send the onWheel event with the ctrl modifier key flag set to true. I’ll write a fix asap.

A temp fix would be to check if the ctrlKey flag is set to true in your life onWheel handler.

[andreas-eberle]

I'm using the touchpad of my Dell XPS 15 with Windows 10 in Firefox.
I'm not setting domTarget.
And yes, I can confirm, the ctrlKey flag is set for pinches. Thanks for the hint and thanks for fixing it!

[dbismut]

@andreas-eberle I've released 6.0.0-beta.2 just now, which does the below regarding this issue:

• Adds a warning when using trackpad zoom without a domTarget or event.passive set to true.
• Doesn't trigger the onWheel handler when the ctrl key is pressed and onPinch is active
• Adds a gesture key to the event passed to handlers indicating which gesture originated the event.

Regarding the first point, the pinch-zoom on a trackpad should be default prevented, to avoid the wheel event propagating to the window. If you attach the handlers directly in React, non-passive events aren't supported, therefore event.preventDefault() doesn't work as it should.

Note that there's a few breaking changes in 6.0.0 (mostly renames though) so you might prefer waiting until tomorrow so that I can also fix 5.2.x.

[andreas-eberle]

@dbismut: I tried out version 6.0.0-beta.2. However, I still get the onWheel() callback when pinching.

My code looks like this:

export interface Props {
	zoomHandler(zoomOut: boolean, pinch: boolean): void
}

const ZoomContainer: FunctionComponent<Props> = (props) => {

	const onWheel: Handler<Coordinates> = (state) => {
		const direction = state.direction[1]

		console.log(`onWheel(direction: ${direction}, ctrlKey: ${state.ctrlKey})`)

		if (direction !== 0) {
			props.zoomHandler(direction < 0, false)
		}

		if (state.event) {
			state.event.preventDefault()
		}
	}

	const onPinch: Handler<DistanceAngle> = (state) => {
		const direction = state.direction[0]

		console.log(`onPinch(direction: ${direction}, ctrlKey: ${state.ctrlKey})`)

		if (direction !== 0) {
			props.zoomHandler(direction > 0, true)
		}

		if (state.event) {
			state.event.preventDefault()
		}
	}

	const ref = React.useRef(null)
	const bind = useGesture({onWheel, onPinch}, {event: {passive: false, capture: false}, domTarget: ref})
	React.useEffect(bind, [bind])

	return <div ref={ref}>
		{props.children}
	</div>
}

and when I pinch, I get the following output in the console:

onPinch(direction: 1, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: -1, ctrlKey: true) ZoomContainer.tsx:19
onPinch(direction: 1, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: -1, ctrlKey: true) ZoomContainer.tsx:19
onPinch(direction: 1, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: 0, ctrlKey: true) ZoomContainer.tsx:19
onPinch(direction: 0, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: 1, ctrlKey: true) ZoomContainer.tsx:19
onPinch(direction: -1, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: 1, ctrlKey: true) ZoomContainer.tsx:19
onPinch(direction: -1, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: 1, ctrlKey: true) ZoomContainer.tsx:19
onPinch(direction: -1, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: 1, ctrlKey: true) ZoomContainer.tsx:19
onPinch(direction: -1, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: 1, ctrlKey: true) ZoomContainer.tsx:19
onPinch(direction: -1, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: 1, ctrlKey: true) ZoomContainer.tsx:19
onPinch(direction: -1, ctrlKey: true) ZoomContainer.tsx:33
onWheel(direction: 1, ctrlKey: true) ZoomContainer.tsx:19

Am I doing something wrong? Or is there still an issue in the library?

[dbismut]

That's really weird, here is the code in the WheelRecognizer:

if (event.ctrlKey && this.controller.actions.has('onPinch')) return

Would you be able to set a simple repro sandbox somewhere?

Here is a csb where the left square reacts to wheel, and the right square should react to pinch.
https://codesandbox.io/s/react-use-gesture-issue-wheel-fj4rc

Do both square update on pinch on your end?

[andreas-eberle]

If you change the code of the callbacks in your sandbox to:

      onWheel: ({ offset: [, oy] }) => {
        console.log('onWheel')
        set({ wheel: oy, immediate: true })
      },
      onPinch: ({ offset: [d] }) => {
        console.log('onPinch')
        set({ pinch: d, immediate: true })
      }

You can see in the console that onWheel and onPinch are called, when you pinch (at least it is that way for me).

[dbismut]

Hm indeed my code is a bit dumb since I’m not showing the same offset index 😅 I’m on my phone and will only be able to check that back later tonight. Can you confirm this is also happening on Chrome? does this (both gesture logging in the console) also happen when you wheel while physically pressing the ctrl key?

[andreas-eberle]

• I can confirm that it behaves the same in Chrome.
• Using ctrl+scrolling looks like using the pinch gesture (it logs onWheel and onPinch).

[dbismut]

There must have been an issue when I published on npm. Please try 6.0.0-beta.3, my sandbox has been updated and it works properly. Sorry about this.

[tommedema]

• gesture

@dbismut I have version 7.0.5 and this property is not available, also it says pinching: false even though I am definitely pinching (on an iPhone XS Max in Safari)

also how do you know if it is a zoom-in pinch or a zoom-out pinch?

[dbismut]

@tommedema the capture shows that the gesture is no longer active so this is not surprising that pinching is false. Zoom in means that the movement displacement between your fingers has increased. So movement[0] which measures the distance delta of the whole gesture should be positive. Zoom out is movement[0] being negative.