Comments (5)
What locale do you use? Which browser and version?
from evolve.
I had the same bug in Chrome, but not in Firefox. I analyzed the problem and it is indeed in the linked line. On a fresh start, custom race is just an empty object. Internally sort
performs a number of comparisons between elements of the array (here Object.keys(races)
) and it happens that the function inside did not work when the custom race happened to be on the left side of the comparison (trying to get localeCompare
from undefined
races[a].name
), but worked fine when it was on the right (races[b].name
being correctly undefined
). When I reversed the direction of the check, it stopped working in Firefox too, as expected. A simple workaround here is to use coalescing operator ??
here on races[a].name
, though it is not used elsewhere in the project, so I'll just use ||
to maintain maximum compatibility with old EcmaScript. I'll make a pull request with a quick fix.
from evolve.
This patch makes sense.
Equilibrium might be further in the game than I am. Why would there be no race name?
from evolve.
Specifically the custom race did not have the name. Custom race had races[a]
equal to {}
. My guess is that before it is set the first time or maybe even in the runs where it is not the active one, it is not set. However, I haven't actually seen where it is set.
from evolve.
The issue was already fixed in 1.3.10.
from evolve.
Related Issues (20)
- Can't build Freight Yards HOT 1
- Queue key only works when input method is English
- [Bug?] Cataclysm iridium mine production is a fifth of what the tooltip says
- Soft reset did not revert the "Space Colonist" achievement
- Wiki fails to display Tech & Truepath Tech categories during evolution
- Add soldier count to the resource list
- Cannot hire mercenary
- [minor bug] Replicator Scheduler causes erroneous available power display
- Verrazzano incorrectly awarded
- Suggestion: Reskin the W*ndigo HOT 1
- [Bug] Lake of Blood Transports don't require crew after reenabling HOT 1
- [Bug] Cannot Assign Craftsmen - No Foundry (after 2024/8/6 update)
- Achievement "Cult of Personality" not showing in message log HOT 1
- Wiki Clarification: Knowledge Spent HOT 1
- Safety Deposit Box HOT 2
- Bioscience lab and Wardenclyffe are missing from the wiki but show up in search HOT 2
- Cataclysm Aluminium and Uranium production not boosted by Ziggurat HOT 2
- Scout the Pit mission not affected by Heavyweight Champ perk HOT 1
- Wiki clarification: Outerplane Summon entry does not specify that Absorbtion Chamber must be built to unlock tech
- Unfathomable surface dweller randomness seems potentially bugged
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from evolve.