TODO: impl `pickle` module

[blueloveTH]

TODO: impl `pickle` module

[blueloveTH]

Good luck to you. If you have any questions, just put it here and I will provide help as possible as I can.

[parthvnp]

@blueloveTH Are you looking for contributions to this module? If so, I am eager to work on it.

[blueloveTH]

What do you mean packing or unpacking? I'm not familiar with the functionality of struct.

We can invent a custom protocol if emulating cpython is complex or it requires a lot of internal change. And it may be the correct way.

The total LOC of pocketpy is ~8000 I think the pickle module should use a solution less than 1000 LOC. We need a clever/light way to achieve that.

I recommend to make a comprehensive plan before actually implementing the module. I invite you to join our Discord for fast communication.

https://discord.gg/5BjbBfDE

[parthvnp]

Perfect. Thank you. I do have a plan in place, I will refine and it share it on discord!

[blueloveTH]

Yes, sure. I need help!
I was looking at cpython's pickle module, it seems cpython use a special virtual machine for it. However, it is a bit complex.

[parthvnp]

I can give it a try. I will use the implementations that already exist for the standard library in python and then try to emulate the CPython pickle module within the constraints that exist for pocketpy. First, I will try to come up with an external that is as close as possible to the one in standard library and then we can go from there.

[parthvnp]

I have started working on the initial implementation for the Pickle module. However, I am currently facing one major issue. Pickling and unpickling heavily rely on struct module for packing and unpacking Python objects. This functionally is implemented in C layer. Currently we don't have any similar functionality to support unpacking and packing of objects directly in the C layer. Should we implement this functionality in the C layer or provide minimal implementations of struct module functions directly in Python?

[blueloveTH]

I'd like to develop this module myself.