Comments (6)
I wrote the listener-helper as you pointed out because:
- It is simple that not supporting multiple listener-helper 😄
- It saves less line-of-code when using multiple listeners
For example, instead of this:
basis.setOnItemSelectedListener(new AdapterView.OnItemSelectedListener {
def onItemSelected(p1: AdapterView[_], p2: View, p3: Int, p4: Long): Unit = { doSomething() }
def onNothingSelected(p1: AdapterView[_]): Unit = { }
})
This saves LOC dramatically:
basis.onItemSelected(doSomething())
Meanwhile, this can be an improvement as well, but less impressive:
basis.onItemSelected(doSomething())
basis.onNothingSelected(doAnother())
As you mentioned, addSomeListener
approach can be a solution enabling this. But it costs runtime overhead on memory, CPU, and the size of compiled jar. I did not decided that it is worth doing in spite of these overheads.
I admit that it is not documented (non-) feature. One of the most pressing issue is documentation.
from scaloid.
I agree. Then how about a macro shows a warning about using 'unsafe' listener in compile time?
from scaloid.
Developers might get too much warning. Warning usually indicates bad practice, but this is not the case. I think that proper documentation is better.
from scaloid.
Assigning the same listener multiple times is obviously a bad practice though. Is the Scala macro can handle this?
from scaloid.
It will be hard unless the scope is narrow enough. How about to show compile-time warning by default, and allow disabling it by importing specific value? Might need some time though....
from scaloid.
If it takes some time, leave it and moving to other urgent issues would be wise. I will stay opened this issue.
from scaloid.
Related Issues (20)
- Fragments with Sviews HOT 1
- TypedResource(TR) Reload HOT 1
- SArrayAdapter cannot be added to after initialization HOT 2
- java.lang.IllegalArgumentException: Lint HOT 2
- Scaloid with Akka/Play Json or spray HOT 1
- Event gravity does not take parameters or application crashs HOT 9
- sbt android:package HOT 1
- Broken inheritance between S[...] objects (like SView or SLinearlayout) HOT 1
- broadcastReceiver function for String argument inconsistent with the function taking IntentFilter HOT 2
- STextView "here" not working with textSize defined HOT 1
- API 8, 9 support using Scala 2.10 and Scaloid 3.3 HOT 3
- Anko style HOT 1
- String resources getting mixed up when using Java + Scaloid? HOT 2
- problem code `def >> : V = v` HOT 4
- How to dynamically add view components to SLinearLayout or SVerticalLayout HOT 1
- How to initialize LocalServiceConnection from a fragment HOT 2
- no method getVisibleTitleHeight in android.webkit.WebView HOT 2
- How to use dependency injection in an activity. HOT 2
- How is this library implemented? HOT 4
- Performence issue of Scala on android (may not be related to scaloid) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scaloid.