Giter Site home page Giter Site logo

Comments (4)

stinodego avatar stinodego commented on July 20, 2024

I don't really understand what this would add over make pre-commit and make test-all?

from polars.

mcrumiller avatar mcrumiller commented on July 20, 2024

The main pieces missing are the checks in test-rust.yml, which include the feature gate checks that can easily slip through make test-all and make pre-commit. Would you be open to a PR that adds a make test-rust to the makefile, if not the test-ci proposed in this issue?

from polars.

stinodego avatar stinodego commented on July 20, 2024

You really don't want to run cargo-hack locally, it's really expensive. You can already run the Rust tests locally using the Makefile in the crates folder, but the Rust tests are also really expensive/heavy to run.

There is nothing wrong with using GitHub's machines to run the tests/lints for you. As long as people open their PRs in draft there is no issue and we don't get pinged.

I don't see the benefit here, sorry.

from polars.

mcrumiller avatar mcrumiller commented on July 20, 2024

Sure, np.

from polars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.