Set Cookie as Headers instead of Named Paramaters

[polar-fhir]

Set Cookie as Headers instead of Named Paramaters

[palmjulia]

Hi! Thanks for having a look into the code and your detailed description, that's exactly what I need to set it right. It's always a bit hard to implement stuff that you don't actually have a test case for so you input is extremly valuable.

From this documentation and this stack overflow post I was under the impression that cookies are usually set as named parameters.

I've just thought about it and maybe it would be smart if the fhircrackr allowed the user to add an arbitrary header, wouldn't it? Then you could use it to add you cookie and someone else could use it for different purposes. I'll link to this solution as soon as I've got something.

[palmjulia]

Id be happy if you could test the new branch. Install it with remotes::install_github(repo = "https://github.com/POLAR-fhiR/fhircrackr" , ref = "feature_custom_headers").

If I understood it correctly this time, you should be able to pass your cookies like this:

#adding single cookie
fhir_search(..., add_headers = c(Cookie = "key=value"), ...)

#adding multiple cookies
fhir_search(..., add_headers = c(Cookie = "key1=value1;key2=value2"), ...)

Let me know if that works out for you!

[liberaliscomputing]

Thank you again for the swift response, @palmjulia! Yes, I can't agree with you more that allowing users to add custom headers will be a great idea! The above solution seems like exactly what we want and let me test it shortly!

[liberaliscomputing]

@palmjulia, I just tested it and it worked like a charm! Thanks a ton again and I believe you can merged the PR in!

[palmjulia]

Thanks for testing!