Giter Site home page Giter Site logo

Comments (11)

romainsacchi avatar romainsacchi commented on July 3, 2024 1

I think the databases you are trying to fold contain datasets which miss some mandatory fields (in this case, the field unit). I will add a check routine tomorrow, to warn the user of missing fields and print a list of the guilty datasets. I will let you know.

from unfold.

romainsacchi avatar romainsacchi commented on July 3, 2024 1

OK, it is on conda now as well.

from unfold.

romainsacchi avatar romainsacchi commented on July 3, 2024

I think I may have solved the issue.
Can you try to update to v.1.0.3 (from pip, or the latest from conda) and let me know?

from unfold.

romainsacchi avatar romainsacchi commented on July 3, 2024

Hmm, it seems it was not pushed on conda, only pip.

from unfold.

MaximeAgez avatar MaximeAgez commented on July 3, 2024

I updated to 1.0.3. Now I face another Error:

image
image

Seems like it does not think that my database is linked to ecoinvent. But it is linked to ecoinvent.

I tried with other databases in other projects with other versions of ecoinvent and the same error pops up.

from unfold.

romainsacchi avatar romainsacchi commented on July 3, 2024

Hi @MaximeAgez ,

right, I think this is the expected behavior. The purpose of the library is to create a "mask" of a database that contains proprietary data. For example, let's say I made a copy of ecoinvent and modified some markets and some processes throughout the database. I cannot share my modified ecoinvent database, since 95% of it is still original ecoinvent data (as I modified only a few processes). unfold would create a "mask" (in the form of a data package) of that modified ecoinvent database that I can freely share (since it only contains differences between my modified database and the "reference" ecoinvent database). The users would apply this mask to their local original ecoinvent database, to reproduce my modified ecoinvent database.

So, in your case, I suspect "Glencore - Horne" is a database that simply links to the reference database (ecoinvent?), it is not a "modified" version of the reference database, since unfold could not detect any datasets in common.

The typical use I can think of would be when creating prospective LCA databases, which are often just modified ecoinvent databases where electricity markets have been changed, etc. This would allow reproducing these prospective LCA databases without sharing the databases themselves, but only the difference with respect to the unmodified database.

Hence, for example, we have here a list of data packages which one can unfold to reproduce locally some scenario-based LCA databases.

Do you think it deserves a better explanation in the paper/github repo?

from unfold.

MaximeAgez avatar MaximeAgez commented on July 3, 2024

Actually I reread the paper and it makes sense now. I misunderstood the purpose of the software but it's clearly stated, I was probably not as focused as I should have been.

I successfully folded and unfolded two premise-generated ecoinvent databases. But there is something that seems strange to me. Before folding the two databases had respectively 35549 and 34575 activities (it's ecoinvent_image_SSP2-Base_2023 and ecoinvent_image_SSP2-RCP19_2023, using ecoinvent3.8 cut-off).

image

After unfolding them in another project, the 1st one has now 34575 activities:
image

Is that an expected behaviour?

from unfold.

romainsacchi avatar romainsacchi commented on July 3, 2024

It is indeed surprising.
Do you think you could help by running something like:


bw.project.set_current("premise")
list_act_db1 = [(d["name"], d["reference product"], d["location"]) for d in bw.Database("ecoinvent_image_SSP2-Base_2030")]

bw.project.set_current("ecoinvent3.8")
list_act_db2 = [(d["name"], d["reference product"], d["location"]) for d in bw.Database("ecoinvent_image_SSP2-Base_2030")]

print([d for d in list_act_db2 if d not in list_act_db1])

from unfold.

MaximeAgez avatar MaximeAgez commented on July 3, 2024

image

from unfold.

romainsacchi avatar romainsacchi commented on July 3, 2024

Hi @MaximeAgez,
indeed, thanks for noticing that. These redundant datasets belong to other folded scenarios.
Although they are orphans and empty, having them there is not nice.
In a few minutes, v.1.0.4 should be released, preventing this.

from unfold.

MaximeAgez avatar MaximeAgez commented on July 3, 2024

Works for me now. Thanks!

from unfold.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.