Didn't Process Discord Canary and PTB Message Permalink Correctly

[poldekpl]

Didn't Process Discord Canary and PTB Message Permalink Correctly

[bagusnl]

Fixed the issue by adding some line of codes after line 296

            if re.search(r"https://ptb.discordapp\.com/channels/\d+/\d+/\d+", ctx.message.content, re.I) != None:
                return "discord link"
            if re.search(r"https://canary.discordapp\.com/channels/\d+/\d+/\d+", ctx.message.content, re.I) != None:
                return "discord link"

I know it might be not a great solution knowing that I have 0 knowledge in progamming, let alone python, and I just basically strip the existing code and added one word on it. But at least it works.

Edit: Markdown error and added comment

[PoldekPL]

Hello, thank you very much for reporting this issue. Sorry for the late reply, but I only found time now to return to this.

I was not even aware of the PTB and Canary Discord environments. I do my development and testing in stable release of Discord, so currently I'm not able to test the changes myself. However, if the messages themselves are not structured differently in them, supporting those links should be very easy - I have changed the link-detecting regex from

https://discordapp\.com/channels/\d+/\d+/\d+

to

https://(ptb\.|canary\.){0,1}discordapp\.com/channels/\d+/\d+/\d+

and, at least when testing with regex101, it seems to correctly detect both normal and ptb/canary links.

Now, I'll add this change to the repository, but only once I get the bot running again, and for that I'll have to update the bot to run on discord.py 1.5.0 with Intents, so it'll be a few days.

[PoldekPL]

The change mentioned above has been added to the repo. If you want to, you can check now if it works in PTB/Canary environments.

[bagusnl]

Unfortunately it didn't work and return canary and ptb link as a link and not detect the attachment

[PoldekPL]

Okay, I installed Canary and verified the issue. However, I have also immediately noticed my error in the regex. While the example I posted the the first comment is correct, what I added to the code has the optional part in the wrong place. The correction 3d4a283 has been pushed to the repo and now it seems to work correctly:

[PoldekPL]

I have done more testing - especially during reimplementing batch mode - and found that, at least in Canary, the domain in the links to messages has changed from discordapp.com to discord.com. Since the stable release of Discord still returns discordapp.com, both possibilities are now handled by the bot.