scroll-other-window doesn't work

[politza]

scroll-other-window doesn't work

[politza]

https://gist.github.com/politza/3f46785742e6e12ba0d1a849f853d0b9#file-scroll-other-window-el

[WorldsEndless]

That this should not be done in PDF-Tools and that the scroll-other-window functions need to be improved is true, but this functionality is simply too useful for me to pass up, so I'm sharing the code I wrote to achieve this (I spend a lot of my time studying PDFs and taking notes in an adjoining window), which also works for other-window scrolling in info mode and any other mode you care to specify. Hopefully it will be useful to others.

http://www.toryanderson.com/files/pdf-other-window.el

[jagrg]

Here's a fix that works for me in case anyone needs it.

(defun my/scroll-other-window ()
  (interactive)
  (let* ((wind (other-window-for-scrolling))
         (mode (with-selected-window wind major-mode)))
    (if (eq mode 'pdf-view-mode)
        (with-selected-window wind
      (pdf-view-next-line-or-next-page 2))
      (scroll-other-window 2))))

(defun my/scroll-other-window-down ()
  (interactive)
  (let* ((wind (other-window-for-scrolling))
         (mode (with-selected-window wind major-mode)))
    (if (eq mode 'pdf-view-mode)
    (with-selected-window wind
      (progn
        (pdf-view-previous-line-or-previous-page 2)
        (other-window 1)))
      (scroll-other-window-down 2))))

[holtzermann17]

I've found that the Gist posted by @politza works for my use case; I wanted to post this code with a couple other steps that I needed to polish off the integration, hoping this saves someone else some time:

(require 'scroll-other-window)
(add-hook 'org-noter-notes-mode-hook #'sow-mode)
(setq org-noter--inhibit-location-change-handler t)

[politza]

That's a matter of scroll-other-window not being configurable which function it should use to scroll the window, i.e. it always calls window_scroll, a C function. Similar problem occurs when the other window displays a info node.

[WorldsEndless]

I believe this should still be possible. My approach is as follows:
Rebind C-M-v to a function that checks to see if other-window-for-scrolling is PDFView mode and then use the appropriate scroll function, or use the regular scroll-other-window.

However, I can't find a way to get PDFView's mode; I've tried (derived-mode-p) but PDFView doesn't seem to derive, and there seems to be no function like (doc-view-mode-p) for PDFView mode. Do you have any suggestions on moving forward on this?

[politza]

"Tory S. Anderson" [email protected] writes:

I believe this should still be possible.

Sure, but it should not be fixed in pdf-tools. Maybe you want to open
a (Emacs) feature request / bug-report.

However, I can't find a way to get PDFView's mode; I've tried
(derived-mode-p) but PDFView doesn't seem to derive [...]

That should be fixed sometime. You can use pdf-util-pdf-buffer-p' or pdf-util-pdf-window-p'.

[politza]

"Tory S. Anderson" [email protected] writes:

That this should not be done in PDF-Tools and that the
scroll-other-window functions need to be improved is true, but this
functionality is simply too useful for me to pass up,[...]

Why don't you open a feature-request for Emacs ?

[WorldsEndless]

Where/how is feature-request for emacs done?

[politza]

"Tory S. Anderson" [email protected] writes:

Where/how is feature-request for emacs done?

M-x report-emacs-bug RET

[WorldsEndless]

Using the function I made I see some curious behavior that I can't understand. Scrolling down from the other window works as expected, however, scrolling up makes invisible changes UNLESS a) I switch to the buffer, which causes it to update and show me where it is now (after however many scroll-ups I've done), or b) a page-break has occurred, when it shows me the correct other-window regardless. This behavior doesn't seem to occur with scroll-down, which displays every time. Any idea why this would be? is there some difference in implementation of scroll up vs. scroll down?