Giter Site home page Giter Site logo

ChainX Plugin Request about app HOT 52 CLOSED

polkawallet-io avatar polkawallet-io commented on July 30, 2024
ChainX Plugin Request

from app.

Comments (52)

RomeroYang avatar RomeroYang commented on July 30, 2024 2

@RomeroYang How are you doing? When will we launch the new release?

Working on new features, this may take several days.

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024 2

will do, we have a release this week with this update 7f30c70

from app.

true-eye avatar true-eye commented on July 30, 2024 1

Sure!

Also updated the issue content with hash

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024 1

Some issues in the code you need to update:

  1. use flutter_svg: ^0.19.3 in pubspec.yaml.
  2. update type of tokenSymbol and tokenDecimals to List, see #24 .

The latest polkadot-js/apps staking page shows the blocks nominations status of validator, if your plugin need this update, see the latest change of https://github.com/polkawallet-io/sdk.

from app.

true-eye avatar true-eye commented on July 30, 2024 1

Thanks for the guide!
Updated. the flutter_svg, tokenSymbol & tokenDecimals.
For blocks nomination, it doesn't need for ChainX.

Hash: 39573cfbf005e061ca31b3b884b2bc428a622930

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024 1

Polkawallet SDK updated to v0.1.4 now, you need to update signTxAsExtension and signBytesAsExtension in js_service_chainx/src/service/keyring.ts, see polkawallet-io/sdk@d43e7d5.

from app.

true-eye avatar true-eye commented on July 30, 2024 1

@RomeroYang Finally, fixed all issues. Please check. Thanks

from app.

true-eye avatar true-eye commented on July 30, 2024 1

@RomeroYang Added bunch of staking functionalities (vote, rebond, claim, unbond, refresh)
The new hash: 07b601d0aaae0b173e7a18006f7502b9bb55b32d
Please update, Thanks

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024 1

What should I do for this update?

you should update the genesisHash string like this: polkawallet-io/polkawallet_plugin_laminar@6da394e

the one in networkSpect.ts file is for off-line-signature, and the one in plugin.dart file is for network check while sending tx.
you can get the genesisHash through api.genesisHash.toString() in js env.

from app.

true-eye avatar true-eye commented on July 30, 2024 1

I've updated the sdk version to 0.1.6.

  • added genesisHash.
  • For networkSpec.ts file, added CHAINX (genesisHash, SubstrateNetworkKeys)

0.1.6 hash: 0692cbb02da9cfd59eae2856e6e2819c072d4cd3

from app.

true-eye avatar true-eye commented on July 30, 2024 1

@RomeroYang I think, the new version was only released on IOS. Any plan to release on Android?

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

We want to use a new version of polkawallet-io/sdk in next release, but the new one is not published yet.

So you may need to use the develop branch of polkawallet-io/sdk and polkawallet-io/polkawallet_plugin_kusama, do some modification and wait for a new polkawallet-io/sdk release in pub.dev.

from app.

true-eye avatar true-eye commented on July 30, 2024

@RomeroYang Thank you for letting me know.
When will the new version of SDK be released?
And is the develop branch of polkawallet_plugin_kusama mainly updated? Or should I also wait for that?

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

@RomeroYang Thank you for letting me know.
When will the new version of SDK be released?
And is the develop branch of polkawallet_plugin_kusama mainly updated? Or should I also wait for that?

It will be released in this week. You may wait for the master branch update.

from app.

YuQiYang avatar YuQiYang commented on July 30, 2024

@RomeroYang Thank you for letting me know.
When will the new version of SDK be released?
And is the develop branch of polkawallet_plugin_kusama mainly updated? Or should I also wait for that?

noticed that SDK had update, please continue ChainX plugin

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

@RomeroYang Thank you for letting me know.
When will the new version of SDK be released?
And is the develop branch of polkawallet_plugin_kusama mainly updated? Or should I also wait for that?

noticed that SDK had update, please continue ChainX plugin

The new SDK will be released this week, ChainX plugin may be in next week.

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

New SDK was released: https://pub.dev/packages/polkawallet_sdk

  1. add gradientColor and backgroundImage for new UI.
  2. JSChannel was changed to https://localhost:8080/ in js_api/src/index.ts.
  3. add networkMetadata for offline-signature.

from app.

true-eye avatar true-eye commented on July 30, 2024

Yes. I will update them as soon as possible.

from app.

true-eye avatar true-eye commented on July 30, 2024

@RomeroYang I've updated the (1) & (2).
Not sure what I should do for (3). Is there any plugin (polkawallet_plugin_kusama or polkawallet_plugin_acala) that I can see the example updates?
Thanks

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

see: polkawallet-io/sdk@2cc14c7

  1. create chainX metadata.ts in js_service_chainx/src/constants/ like js_api/src/constants/networkMetadata.ts
  2. update signAsync() function in js_service_chainx/src/service/keyring.ts.

from app.

true-eye avatar true-eye commented on July 30, 2024

Thanks, I've updated!
By the way, what should be the metadata string for ChainX?

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

A easy way to get the metadata of a substrate-based chain is:

  1. open a web page which can connect to a node through ws/wss in Chrome.
  2. open the Devtool, go to Network panel, and find the ws connection.
  3. you'll find the result of a state_getMetadata request, that's the string you need.
    image

from app.

true-eye avatar true-eye commented on July 30, 2024

cool man! Thanks. I will

from app.

true-eye avatar true-eye commented on July 30, 2024

Done!

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

Done!

Could you paste a plugin repo commit hash here? so I can use a specific version of your plugin.

And you also need to submit a commit hash here if your plugin has a updated version in the future.

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

I just add your plugin in the App in dev, find some image files need update.

  1. chainx_gray.png should be a shap in gray, and the color is #9e9e9e. It should have a little padding, because it looks a bit big now:
    image

  2. bg.png should have a transparent background color, it will display as texture on a block with themeColor, like below:
    image

but chainX has a bright yellow theme color, so I think your bg.png should have a dark background, like this:
image

now it looks like this in the app:
image

  1. you'd better delete the unused assets like polkadot.png, staking_pink.png for reducing the package size.
  2. staking.png and governance.png were replaced with svg images, see develop branch of polkawallet_plugin_kusama.

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

Unhandled Exception: type 'String' is not a subtype of type 'int' for ValidatorData.registeredAt

image

And there's a WARNING in your ts file:

I/chromium(13723): [INFO:CONSOLE(33)] "@polkadot/types-known has multiple versions, ensure that there is only one installed.
I/chromium(13723): Either remove and explicitly install matching versions or deupe using your package manager.
I/chromium(13723): The following conflicting packages were found:
I/chromium(13723): 	3.11.1	<unknown>
I/chromium(13723): 	3.11.1	<unknown>", source:  (33)

you can test your js_service_chainx code in Chrome console through opening js_service_chainx/test/index.html.

from app.

Exxibition avatar Exxibition commented on July 30, 2024
  1. chainx_gray.png should be a shap in gray, and the color is #9e9e9e. It should have a little padding, because it looks a bit big now:

I noticed the gray version of the DOT icon has 2 gray tones. I assume I can simply make a lighter version of the current icon but with different shades. All based off #9e9e9e of course.

  1. staking.png and governance.png were replaced with svg images, see develop branch of polkawallet_plugin_kusama.

Am I looking at the correct pictures of a 'hand' for staking and the 'voting ballot' for governance?

from app.

Exxibition avatar Exxibition commented on July 30, 2024

As for the bg.png, shouldn't that be more of an effect on yellow then? Like Polkadot? I'd much rather go along with the theme colour with an effect over it, than stick out from the app's design choices and make a dark background with yellow accents

from app.

true-eye avatar true-eye commented on July 30, 2024

@RomeroYang Fixed all the issues you mentioned. But not sure why ValidatorData is not working on new release. Is there any data conversion? I would like to test on my side but I think the app and other plugins are not updated on github as master.. So can't setup on local. However, I've fixed so please check again.

Thanks!

ced17371c4b35f8ea97c155bec102caa5af39e54

from app.

Exxibition avatar Exxibition commented on July 30, 2024

@RomeroYang Do you have an update for us regarding the above?

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

@RomeroYang Do you have an update for us regarding the above?

Working on Acala TC6 upgrade now, I will look into it next week.

from app.

true-eye avatar true-eye commented on July 30, 2024

Hi, @RomeroYang
I hope you are doing well. Just greetings. :)

from app.

Exxibition avatar Exxibition commented on July 30, 2024

Hey @RomeroYang Sorry to press you again. Could you give us a little update on the timeline, anything we can do to help out?

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

We have a polkawallet_ui package update today, see #24 (comment)

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

Waitting for your update @true-eye

from app.

true-eye avatar true-eye commented on July 30, 2024

@RomeroYang I've updated polkawallet_ui git ref and signTxAsExtension/signBytesAsExtension. please check

from app.

true-eye avatar true-eye commented on July 30, 2024

@RomeroYang I've found some interface mismatch after upgrading the app. I need to fix them. I will let you know once fix

from app.

true-eye avatar true-eye commented on July 30, 2024

@RomeroYang How are you doing? When will we launch the new release?

from app.

true-eye avatar true-eye commented on July 30, 2024

@RomeroYang I hope you are doing well.

The ChainX plugin has been updated with the following

  • unfreeze feature
  • unbound issue fixed
  • use custom identity module

the new hash: 225f62ae68adfef0d50bdb4d2eb6a34e4f518269
Please update, thanks

from app.

true-eye avatar true-eye commented on July 30, 2024

@RomeroYang When will we release the next version? any hope this month?

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

We will have sdk v0.1.6 in next version, preview of the update here: polkawallet-io/polkawallet_plugin_laminar@6da394e

from app.

true-eye avatar true-eye commented on July 30, 2024

What should I do for this update?

from app.

true-eye avatar true-eye commented on July 30, 2024

Could we release the minor version with chainx update before the sdk update, please?

from app.

true-eye avatar true-eye commented on July 30, 2024

will do, we have a release this week with this update 7f30c70

@RomeroYang Did we launch this?

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

New sdk 1.0.8 released! Check the changes in latest commits of branch develop of polkawallet_plugin_kusama.

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

The App is ready for new release, please update to polkawallet_sdk 0.1.8+ and submit as soon as possible.

from app.

Exxibition avatar Exxibition commented on July 30, 2024

Sorry RomeroYang I have two questions:

  1. Do you mean this one? polkawallet-io/polkawallet_plugin_kusama@66fd0e5

  2. Is there a chance that we could hire the PolkaWallet team to include updates from your side in our plugin? (i.e. only when we want to add functionality to chainx directly, we can do so, but other maintenance etc would be done by you, like this SDK update)

I'd be more than happy to discuss, please let me know in Telegram t.me/Exxibition

from app.

Exxibition avatar Exxibition commented on July 30, 2024

@RomeroYang Please see my latest message in Telegram

from app.

Exxibition avatar Exxibition commented on July 30, 2024

Hi Romero,

The team has built an updated version here: https://github.com/chainx-org/polkawallet_plugin_chainx

I believe they contacted you on the matter, but I just wanted to make sure 😊

Let me know the progress please and whether we need to amend anything.

from app.

RomeroYang avatar RomeroYang commented on July 30, 2024

@Exxibition The new plugin is not functioning, I have notified the developer to fix it last week.

from app.

Exxibition avatar Exxibition commented on July 30, 2024

I heard yesterday. Thank you Romero!

from app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.