Comments (5)
put the text "Opinions ยท September 7, 2016" inside anh1
Is that referring to the content that's currently inside the .date-line
div?
from news.
@robdodson yeah
from news.
@blasten Are those things you listed are still something we want to fix? Since @keanulee is working on a11y maybe he can take a look?
from news.
It's hard to determine what level headings the related content should be. On the article page, the title of the article should be h1, and the article content may contain h2 and h3. I'm thinking maybe the only change needed is to change "Most Read", "More Top Stories" and "Opinions" to h4 so they don't collide, but I don't think that's super important when using the screen reader across the page.
from news.
yeah, I think we should fix them. I agree with @keanulee that it isn't very clear which headings to use, but I think it's fine if they collide though since the article content is inside <article>
.
from news.
Related Issues (20)
- Add page-not-found for invalid paths
- On Firefox, items in sticky-nav are layout as a single column
- On IE11, the items on the list page are not layout correctly
- Image resizes when you scroll down HOT 2
- On iOS, you can swipe to scroll the main content when the left nav drawer is open
- Remove the search icon HOT 1
- AMP? HOT 2
- a11y: Using keyboard with Firefox HOT 1
- a11y: missing alt attribute
- a11y: missing aria-label
- Share server push strategies HOT 4
- When sharing on Social Media such as Twitter & Google+, metadata is not displayed HOT 4
- Polymer CLI and News App Build Issue
- Expired certificate for news-docs.polymer-project.org HOT 1
- warnning
- About page HOT 6
- News-path-warning does not work
- Link to old version of polymer
- Swipe for next article causes issues with vertical scrolling
- Polymer-template
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from news.