Comments (4)
sent a PR #91
from node-flickrapi.
Hm, in this case I'd not make this a two level object, but make that an explicit value in the options, like requestTimeout
in the options, and then unpacking that value when giving request
the options it needs.
Using request.defaults(options.requestOptions)
means that rather than offering a way to do timeouts, we're offering a way to do everything that request.defaults
lets you overwrite, in which case we should tell people where the documentation for that is, instead of claiming that there's only one value supported.
Either way, the PR will probably need a bit of a rewrite to either offer a dedicated value for just this specific use, or to handle the request options object as literally that; an object to pass into request.defaults
from node-flickrapi.
If another day someone wants to add another option to the request.defaults, like gzip: true
, then (s)he would have to write add that explicitly to this library. So I think letting the user pass the defaults to the request.defaults as is will be better.
from node-flickrapi.
agreed - if you can update the link to the request.default docs specifically I think we can just merge this in.
from node-flickrapi.
Related Issues (20)
- overhaul the code to ES6, with as much code replaced by now-available packages. HOT 6
- Uploading an image results in an empty array and the application hanging HOT 12
- Access granted doesn't include write permissions HOT 4
- Flickr.tokenOnly is not getting fired. HOT 3
- Pass on the error code from Flickr to the callback function.
- Sort many photosets with 'flickr.photosets.orderSets' fails (URI too long) HOT 5
- Video support? HOT 1
- Can't get original photos, not authenticated HOT 5
- Add `Flickr.proxy` to obviate `new Flickr` when proxying.
- TypeError: Cannot read property 'photos' of undefined HOT 1
- Document a note about building the IA index. HOT 3
- No results when using min/max_taken_date HOT 7
- Authorization from an Electron App HOT 6
- Issue with long load times for initiating the Flickr API HOT 11
- Part of string can't setMeta() HOT 1
- API is broken HOT 6
- does API supported URL, streaming, buffer upload ? HOT 3
- Cannot find module './src/FlickrApi HOT 3
- Returned photo results are insufficient, photo property only contains five photo objects when there are clearly more photos HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-flickrapi.