Giter Site home page Giter Site logo

Comments (4)

 avatar commented on June 27, 2024

sent a PR #91

from node-flickrapi.

Pomax avatar Pomax commented on June 27, 2024

Hm, in this case I'd not make this a two level object, but make that an explicit value in the options, like requestTimeout in the options, and then unpacking that value when giving request the options it needs.

Using request.defaults(options.requestOptions) means that rather than offering a way to do timeouts, we're offering a way to do everything that request.defaults lets you overwrite, in which case we should tell people where the documentation for that is, instead of claiming that there's only one value supported.

Either way, the PR will probably need a bit of a rewrite to either offer a dedicated value for just this specific use, or to handle the request options object as literally that; an object to pass into request.defaults

from node-flickrapi.

 avatar commented on June 27, 2024

If another day someone wants to add another option to the request.defaults, like gzip: true, then (s)he would have to write add that explicitly to this library. So I think letting the user pass the defaults to the request.defaults as is will be better.

from node-flickrapi.

Pomax avatar Pomax commented on June 27, 2024

agreed - if you can update the link to the request.default docs specifically I think we can just merge this in.

from node-flickrapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.