Giter Site home page Giter Site logo

Comments (6)

nilslice avatar nilslice commented on May 1, 2024

I don't think it's the root of the problem, but could you update to 1.8 stable and see if you're still hitting this?

I have a feeling it's just that with each write to Bolt, Ponzu runs a sort in a goroutine on the bucket you're impacting and there could be some race issues at the transaction level if too many writes are happening at once.

from ponzu.

nilslice avatar nilslice commented on May 1, 2024

If you do a search for SortContent in the codebase you'll see what I'm referring to. This sorting method isn't an ideal process and should be rethought. But, for the systems I built Ponzu to support the write performance is a very low priority.

I would be happy to find a way to improve this though.

from ponzu.

nilslice avatar nilslice commented on May 1, 2024

There is some code pushed to the throttle-sort (6c34044) branch. If you can test it out, pull it into your master and re-install ponzu by running go install ./... from inside $GOPATH/src/github.com/ponzu-cms/ponzu

On the very first 'load' command, I am seeing a bug that is preventing the SortContent call from being evoked at the right time. Maybe the HTTP calls to github API can finish sooner than the 4-second waitDuration before a secondary / throttled call to SortContent can happen? will have to test a shorter waitDuration value and see.

from ponzu.

nilslice avatar nilslice commented on May 1, 2024

I reduced the waitDuration value and it seems to have resolved this issue. I think the loading feature of the gobservatory project is fairly niche so i don't want to over optimize for it, but it would be good to be sure that those HTTP calls are the cause of the bug I caught.

from ponzu.

nilslice avatar nilslice commented on May 1, 2024

I'm going to close this up for now, since a fix was merged to master. If you get a chance to try it out and successfully replicate the panic you encountered, let me know and I'll dig in.

Thanks for reporting this!

from ponzu.

kkeuning avatar kkeuning commented on May 1, 2024

I was able to test and confirm that with this fix I am no longer getting the panic under high load.

There is a remaining issue with SortContent being not called after the loading completes, submitted #123 to fix.

from ponzu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.