Click/Touch Sidebar Links Not Closing Sidebar

[poole]

Click/Touch Sidebar Links Not Closing Sidebar

[matiassingers]

@sc0ttwad3 hope I understood your question correctly:

The sidebar is hidden/shown by clicking the hamburger icon, what the hamburger icon actually does is simply check a checkbox like you wrote. Going back in the browser will keep the checkbox checked in most modern browsers.

If you want to close the menu upon clicking a link you might want to do something like this in JS for toggling the open/closed state of the checkbox/sidebar:

var element = document.getElementById('sidebar-checkbox');
// toggling the open/close state
element.checked = !element.checked;

// or simply closing the sidebar
element.checked = false;

[sc0ttwad3]

Thanks for the snippet, I actually ended up doing something very similar to
handle that -- albeit I over-engineered the problem -- and much prefer the
economy of your solution! I also modified/animated the hamburger icon by
adapting the method described here:
http://www.elijahmanor.com/css-animated-hamburger-icon/

Thx.

On Mon, Apr 21, 2014 at 11:50 PM, Matias Singers
[email protected]:

@sc0ttwad3 https://github.com/sc0ttwad3 hope I understood your question
correctly:

The sidebar is hidden/shown by clicking the hamburger icon, what the
hamburger icon actually does is simply check a checkbox like you wrote.
Going back in the browser will keep the checkbox checked in most modern
browsers.

If you want to close the menu upon clicking a link you might want to do
something like this in JS for toggling the open/closed state of the
checkbox/sidebar:

var element = document.getElementById('sidebar-checkbox');// toggling the open/close stateelement.checked = !element.checked;
// or simply closing the sidebarelement.checked = false;

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-41001432
.

[mdo]

Yeah it's by design to work as-is. This should be a no-JS interaction to start.