Giter Site home page Giter Site logo

Comments (2)

ArtPoon avatar ArtPoon commented on July 19, 2024

This seems to be where p-values are being calculated for the RDP method:

OpenRDP/openrdp/rdp.py

Lines 165 to 175 in bb02000

# Calculate p_value
val = 0
log_n_fact = np.sum(np.log(np.arange(1, n+1))) # Convert to log space to prevent integer overflow
for i in range(m, n):
log_i_fact = np.sum(np.log(np.arange(1, i+1)))
log_ni_fact = np.sum(np.log(np.arange(1, n-i+1)))
with np.errstate(divide='ignore'): # Ignore floating point error
val += np.math.exp((log_n_fact - (log_i_fact + log_ni_fact)) + np.log(p**n) + np.log((1-p)**(n-i)))
uncorr_pvalue = (len_trp / n) * val
corr_p_value = G * uncorr_pvalue

from openrdp.

ArtPoon avatar ArtPoon commented on July 19, 2024

On line 172, we should be taking the power out of $\log(p^n) = n\log(p)$ when calculating the binomial probability
Also need to look at how G is being calculated as a possible issue

from openrdp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.