Remove node-sass

[Crashillo]

Remove node-sass

[furilo]

Removing webpacker would be an option? https://www.simplethread.com/rails-7-the-end-of-webpacker/ https://world.hey.com/dhh/rails-7-will-have-three-great-answers-to-javascript-in-2021-8d68191b

[ferblape]

Yeah, that's totally an option! I don't if that's a step too far on the path.

Maybe first we can migrate from node-sass to dart-sass which is the future, and with that we'll be closer to drop Webpacker. Removing webpacker will require to consider the different alternatives. I think the next step is to study https://github.com/rails/jsbundling-rails and understand if it allows us to migrate from Webpacker to esbuild without suffering too much.

[Crashillo]

Definitely it's an option, but as @ferblape said, it's too early. On one hand, rails 7 is yet freshly baked and on the other hand we need to pave the way before such breaking change. Step by step, the project must get rid of the outdated stuff, I'd try to migrate to webpacker 6 (because it's the most up-to-date milestone) and finally we'll dismiss webpacker once the previous steps are done.

[ferblape]

Hey, in the meantime is it possible to upgrade to node-sass 6? It supports the latest versions of node: rails/webpacker#3217

[Crashillo]

I didn't have so much idea 'bout that, so I tested:

• gobierto hadn't a direct dependency to node-sass, it was through @rails/webpacker
• the release we're using (5.2.1) had node-sass, however, the latest (5.4.3) hadn't
• the link you pointed, it looks like works for webpacker 4.x branch. Gobierto implements 5.x branch
• I successfully run the app with node v16
• let's see if the tests are green and the deploy doesn't break anything.... 🤞

[jorgeatgu]

With the last upgrade to @rails/webpack 5.4.3 the console throws some deprecation warnings from dart sass

Deprecation Warning: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(-$size, 2)

[Crashillo]

Sass offers this migration tool, to make the changes in an automatic way. BUT, I remember I've played already with it and some things gets broken.

I'll create an issue to update the semantics