Giter Site home page Giter Site logo

Comments (2)

dcneiner avatar dcneiner commented on July 18, 2024

@ifandelse I verified this is the case. Tests pass because they run in the browser, but Node usage of Postal is completely broken. You are testing global.hasOwnProperty but not passing in a global parameter as part of the factory method for node. Hence undefined.hasOwnProperty is throwing an error.

I just added a small test before the method call to ensure globals is defined. I also bumped the version number to make it easy to push out. If you'd like the same change without the version number bump, let me know.

from postal.js.

ifandelse avatar ifandelse commented on July 18, 2024

@tsgautier Man I owe a beer (or your favorite beverage) plus a big apology. This is why I should not be allowed to code after having taken a melatonin. :-) @dcneiner and I are working on a chrome devtools extension that will be ready soon, and the new code that snuck in that broke the CommonJS wrapper has to do with it. Sorry for the trouble. This is fixed in 8.0.9 now. I wasn't sure how forcing a republish of 0.8.8 would affect you, so opted to bump the version with the fix. @dcneiner thanks for the fix!

from postal.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.