Giter Site home page Giter Site logo

Comments (13)

wolfgangwalther avatar wolfgangwalther commented on June 9, 2024 2

To be precise:

  • 12.1 is the development version (uneven minor, no patch)
  • 12.2.0 is the proper release (even minor, including patch)

from postgrest.

laurenceisla avatar laurenceisla commented on June 9, 2024 1

I think this is already documented? I can see the deprecation notices in:

from postgrest.

wolfgangwalther avatar wolfgangwalther commented on June 9, 2024 1

Also, I think the next minor should be 12.1.0, since the latest release was 12.0.3 . Unless I'm missing something, postgrest-release should use the current version in postgrest.cabal for a minor release.

No, we agreed that uneven minor releases are the on-going development version.

So the current development version is 12.1. We are going to release 12.2 - and at the same time we switch the main branch to the new development version 12.3. That's all hardcoded in the postgrest-release tool already.

from postgrest.

wolfgangwalther avatar wolfgangwalther commented on June 9, 2024 1

I think we can do a new minor release now. @wolfgangwalther Should just doing postgrest-release be enough?

I still want to check this TODO here:

Add "pg version last supported by pgrst version X" and maybe "support for pg version Y will be removed in next version of pgrst" hints on startup as discussed in #2052 (comment).

So yeah, now it's on me.


I wonder why it didn't find the remote, I have:

Ah my remotes end in .git and I assume this would always be the case:

upstream	[email protected]:PostgREST/postgrest.git (fetch)
upstream	[email protected]:PostgREST/postgrest.git (push)

I will change the script accordingly.

from postgrest.

wolfgangwalther avatar wolfgangwalther commented on June 9, 2024 1

I still want to check this TODO here:

If we do #2052, then the next version should be a major one right? Not opposed if that's the case.

Yes - I would that right after we released the next minor.

from postgrest.

laurenceisla avatar laurenceisla commented on June 9, 2024

I think this is already documented? I can see the deprecation notices in:

Ah, the link from the changelog is not working anymore though. Fixing in #3552

from postgrest.

steve-chavez avatar steve-chavez commented on June 9, 2024

I think we can do a new minor release now. @wolfgangwalther Should just doing postgrest-release be enough?

I just executed it and got:

Current version is 12.1
Updating postgrest.cabal ...
Updating CHANGELOG.md ...
Committing ...
Current version is 12.2.0
Updating postgrest.cabal ...
Committing (devel bump)...
Remote not found. Please push manually ...

I wonder why it didn't find the remote, I have:

git remote -v | grep PostgREST/postgrest
upstream        [email protected]:PostgREST/postgrest (fetch)
upstream        [email protected]:PostgREST/postgrest (push)

from postgrest.

laurenceisla avatar laurenceisla commented on June 9, 2024

Also, I think the next minor should be 12.1.0, since the latest release was 12.0.3 . Unless I'm missing something, postgrest-release should use the current version in postgrest.cabal for a minor release.

from postgrest.

laurenceisla avatar laurenceisla commented on June 9, 2024

No, we agreed that uneven minor releases are the on-going development version.

Ah, got it, it seems that I missed that.

from postgrest.

steve-chavez avatar steve-chavez commented on June 9, 2024

I still want to check this TODO here:

If we do #2052, then the next version should be a major one right? Not opposed if that's the case.

from postgrest.

steve-chavez avatar steve-chavez commented on June 9, 2024

Yes - I would that right after we released the next minor.

Ok cool. So then I think we can release the minor now right?

from postgrest.

wolfgangwalther avatar wolfgangwalther commented on June 9, 2024

Ok cool. So then I think we can release the minor now right?

It depends. If you agree that I can do #2052 afterwards - fine.

In #2052 (comment) we discussed about adding the "this PG version will not be supported in the next major version"-deprecation-style check. This is the TODO I referenced here:

I still want to check this TODO here:

I was under the impression, that you agreed on doing #2052 with the condition that we add this. If so, we'd need to do that before we do the minor. If you're fine without this condition - we can go ahead with the minor release now.

from postgrest.

steve-chavez avatar steve-chavez commented on June 9, 2024

It depends. If you agree that I can do #2052 afterwards - fine.

For sure, I agree with that.

In #2052 (comment) we discussed about adding the "this PG version will not be supported in the next major version"-deprecation-style check. This is the TODO I referenced here:

Oh ok. So we need to add a deprecation plus update this section here?

from postgrest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.