Crumb now working is same route

[poteto]

Crumb now working is same route

[cibernox]

Just to give exact context, the problem is in this lines: https://github.com/poteto/ember-crumbly/blob/develop/addon/components/bread-crumbs.js#L33-L49

That computed property gets updated whenever the user transitions to a route with a different name, but in our case we're transitioning to the same route with a different id.

I don't know if there any public API in the router or the application controller that exposes more information about the value of the dynamic segment of the active route, so that CP can add that as a dependent key.

[gmurphey]

This is fixed in #27.

[cibernox]

@gmurphey Good to know. Do you know if that if going to be blocked much longer?

[gmurphey]

@cibernox It's currently blocked by #30, which is fixed by #31 and just need to be merged.

[gmurphey]

@cibernox #27 does work on its own if you want to use that branch for now. It's just that the tests are failing due to an unrelated issue outlined in #30.

[cibernox]

I asked because #31 seems to be there for around a month, so perhaps was not merged for some problem I wasn't aware.

[poteto]

Super sorry about that guys! I accidentally unwatched the repo so I wasn't getting any notifications.

[gmurphey]

No problem, @poteto! Rebasing #27 now!

[samdemaeyer]

@poteto, @gmurphey
Hi Guys, thanks for the quick release!
There is however an issue, if you use the component like this:

{{#bread-crumbs tagName="ol" outputStyle="bootstrap" linkable=true as |component crumb|}}
  {{#if (eq crumb.title 'Authenticated')}}
    <i class="ti-home"></i>
  {{else}}
    {{crumb.title}}
  {{/if}}
{{/bread-crumbs}}

The output does not generate the <li> & <a> tags any more.
I just updated to the new release. This is how it rendered in 0.2.0:

This is what is being rendered in the new release:

<ol>            
  <i class="ti-home"></i>
  Calendar
  Personal
</ol>

[gmurphey]

Hi, @samdemaeyer! As part of the fix for #30, a bread-crumb component was added to render each individual crumb. I believe your template should become:

{{#bread-crumbs tagName="ol" outputStyle="bootstrap" linkable=true as |component crumb|}}
  {{#bread-crumb route=crumb breadCrumbs=component}}
    {{#if (eq crumb.title 'Authenticated')}}
      <i class="ti-home"></i>
    {{else}}
      {{crumb.title}}
    {{/if}}
  {{/bread-crumb}}
{{/bread-crumbs}}

Let me know if that doesn't work for you. I'm happy to revisit it.

[samdemaeyer]

@gmurphey, Thanks, that makes sense. It works fine! @poteto, could you document this change in the README. Again, thanks for the quick response and the help!

[gmurphey]

@samdemaeyer @poteto just updated the documentation in #39.

[fsmanuel]

@gmurphey can we close the issue?

[fsmanuel]

@samdemaeyer can we close the issue?

[gmurphey]

@fsmanuel Seems okay to close to me. #39 has been merged.