Use standard `time.Duration` for storing/working with durations

[pouriyajamshidi]

Use standard `time.Duration` for storing/working with durations

[pouriyajamshidi]

Thanks @ravsii 🤝

Sounds good to me.

[pouriyajamshidi]

Hey @ravsii,

Not all the decisions we made are fresh in my memory but iircc the use of time.Duration would cause some tricky issues. For instance, we allow the TCP connection a second to establish and we account for that in the timing in a hardcoded way to avoid weird/inaccurate values in reports.

I really need to refresh my memory on this. Let's keep this issue open till I get some time to do a proper dive.

In the meantime you can experiment with it and possibly see if the reports match the "real world" values.

[ravsii]

Thanks, @pouriyajamshidi, understood. I guess those tricky cases come from the same root, which is representing some amount of time as time.Duration.

I would probably try to refactor

tcping/tcping.go

Lines 49 to 53 in 8c3d3b7

	type longestTime struct {
	start time.Time
	end time.Time
	duration float64
	}

to time.Duration and submit a draft-PR, if the initial results between current version and a new one would match. Even if not, we would at least know why it should be the way as it is now.