Giter Site home page Giter Site logo

Comments (2)

ravsii avatar ravsii commented on May 31, 2024 1

Also, it's the same the other way around, as I recently found this while investigating #83 (comment)

tcping/statsprinter.go

Lines 201 to 205 in 2839563

func (p *statsPlanePrinter) printTotalDownTime(now time.Time) {
latestDowntimeDuration := time.Since(p.startOfDowntime)
calculatedDowntime := calcTime(latestDowntimeDuration)
colorYellow("No response received for %s\n", calculatedDowntime)
}

The printer calculates the downtime the way it wants, while, ideally, it should be something close to this (pseudocode):

func (p *statsPlanePrinter) printTotalDownTime() {
	colorYellow("no response received for %s\n", p.downtimeDuration);
}

The JSON printer is guilty of that as well.

from tcping.

pouriyajamshidi avatar pouriyajamshidi commented on May 31, 2024

I agree. it also helps making the code more readable.

from tcping.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.