Giter Site home page Giter Site logo

Comments (9)

PowerBroker2 avatar PowerBroker2 commented on July 22, 2024

Thank you for the kind compliments on the lib, I'm glad it's working for you :)

I'll see what I can do to incorporate WiFi into the library and add a new example.

from elmduino.

PowerBroker2 avatar PowerBroker2 commented on July 22, 2024

Actually, I think I got ahead of myself - I already have an ESP32 WiFi example here. Does it not work for you?

from elmduino.

pascaltippelt avatar pascaltippelt commented on July 22, 2024

Well, your programming skills are faster than the light. Yes, it works, I can finally get values from my old car. 🚙 👍

There is one minor issue with those cheap WiFi adapters: They sometimes close the telnet connection (maybe if there were no requests for a certain time or so). So does you lib check if the telnet client is still connected before a request and, if not, tries to reconnect? Or should this be done manually?

from elmduino.

pascaltippelt avatar pascaltippelt commented on July 22, 2024

Here you can see the first succesfull run of my implementation (still slow as I only poll data once a second).

https://youtu.be/nSUs2budr2M

from elmduino.

PowerBroker2 avatar PowerBroker2 commented on July 22, 2024

There is one minor issue with those cheap WiFi adapters: They sometimes close the telnet connection (maybe if there were no requests for a certain time or so). So does you lib check if the telnet client is still connected before a request and, if not, tries to reconnect? Or should this be done manually?

To keep the library as flexible and simple as possible, any automatic reconnects should be done at sketch-level. You could test for connection issues in the error printing function.

Here you can see the first succesfull run of my implementation (still slow as I only poll data once a second).

https://youtu.be/nSUs2budr2M

Looks good! Are you having problems with the connection if you poll faster than 1Hz?

from elmduino.

pascaltippelt avatar pascaltippelt commented on July 22, 2024

No I don't have problems getting more values. It is for being able so "see" the single values.

Everything fine!

from elmduino.

pascaltippelt avatar pascaltippelt commented on July 22, 2024

So in the loop() I would check Telnet state and then get my value like this?

if (!client.connected()) {client.connect(server, 35000);}
//get Values...

By the way... When exactly is it required to myELM327.flushInputBuff() ?

from elmduino.

PowerBroker2 avatar PowerBroker2 commented on July 22, 2024

I don't have much experience in WiFi programming, but it looks ok to me. Googling might produce some good example code.

myELM327.flushInputBuff() is automatically called so you don't have to. If you experience a lot of ELM327 status errors, you could try calling that function after printing the error, but idk if that would help.

from elmduino.

pascaltippelt avatar pascaltippelt commented on July 22, 2024

Thank you!

from elmduino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.