printerror interval & ELM NO DATA error

[powerbroker2]

printerror interval & ELM NO DATA error

[nices0325]

kia forte 2019..
I tried to buy another elm327 and it works.. I think ELM327 have various issues connecting with arduino ...

anyway, I have checked the values from my

rpm, vehicle speed and the other values seem to be quite correct but engine load and throttleposition seem to be wrong.. As I fully accelerate to 6000 or 7000 rpm, engine load goes up to as far 18% and throttleposition up to 20%. It doesn't seem to be normal. What would be the problem..
p.s I attached engine load grapgh

[nices0325]

actually it's a question category. sorry for not knowing how to modify the categories...

[PowerBroker2]

The no data error means the ELM327 is not getting any data from your car for some reason. Are you testing with your car on and running? Also, please format your code properly

[nices0325]

sure. Car was running .. would it be the porblem of the ELM327 itself? should i buy one more?

[nices0325]

Is there any wrong with my code ?

[PowerBroker2]

it seems more like either a config issue, or your car just doesn't want to send the ELM data. What's your car's make/model/year?

Also, I won't look at your code until you fix its formatting.

[PowerBroker2]

The value returned by the engine load pid needs to be divided by 2.55 to be correct. See here

[nices0325]

sure, I already checked that .. I think throttelposition and engineload doesn't work properly well...plz check below

float ELM327::rpm()
{
	if (queryPID(SERVICE_01, ENGINE_RPM))
		return (findResponse() / 4.0);

	return ELM_GENERAL_ERROR;
}

float ELM327::engineload()
{
	if (queryPID(SERVICE_01, ENGINE_LOAD))
		return (findResponse() / 2.55);

	return ELM_GENERAL_ERROR;
}

float ELM327::enginetemp()
{
	if (queryPID(SERVICE_01, ENGINE_COOLANT_TEMP))
		return (findResponse() - 40.0);

	return ELM_GENERAL_ERROR;
}

float ELM327::throttleposition()
{
	if (queryPID(SERVICE_01, THROTTLE_POSITION))
		return (findResponse() / 2.55);
	
	return ELM_GENERAL_ERROR;
}

float ELM327::intakeairtemp()
{
	if (queryPID(SERVICE_01, INTAKE_AIR_TEMP))
		return (uint32_t)findResponse();

	return ELM_GENERAL_ERROR;
}

float ELM327::fueltype()

{
	if (queryPID(SERVICE_01, FUEL_TYPE))
		return (int32_t)findResponse();

	return ELM_GENERAL_ERROR;
}

[PowerBroker2]

intakeairtemp() needs a -40 bias, but other than that, everything else is correct

[PowerBroker2]

Shot in the dark, but I added a ton of new functions for PID processing (basically everything except oxygen sensor stuff). Give release 2.4.0 a shot and see if it helps

[nices0325]

omg... It's a real dope shit for me... thanks a lot bro
However, the throttleposition response is written 100/255 *A at here https://en.wikipedia.org/wiki/OBD-II_PIDs
but, you divide findResponse by 100 in the cpp file.. What is correct one?

[PowerBroker2]

You're right - I made a typo. It'll be fixed in the next version