Comments (6)
I'd prefer to stick with the right scope names and potentially make pull requests to VS Code's default themes if we can improve them for all languages. It'd be difficult to point people to PowerShell-specific versions of the default themes so I'd like to do things in the "official" way as much as possible.
I can help you get a PR through to VS Code if you can figure out a good way to light up these scopes correctly in their default themes. Showing some comparison with Sublime Text's highlighting for those scopes would also be helpful in convincing them to accept a PR.
from editorsyntax.
Ok. I can play around with the default themes a bit and paste some screenshots here for discussion. And when (if) we think we have found something that works, we can create a PR to try to get the default themes updated :)
from editorsyntax.
Sounds like a good plan!
from editorsyntax.
Btw, @gravejester @daviwil, I have over 280 themes on the vscode gallery,
https://github.com/gerane/VSCodeThemes
I can try to start adding support for these, but might take me a while. I am always open for pull requests on them.
When code first came out, there were like 10 themes, and I'm a huge fan of editor customization and expansion, and I wasn't a big fan of the default themes. I had experience working with atom themes and porting those, so I scripted porting almost 300 themes.
I might need to see what a few of these look like so I know what I'm adding.
EDIT: I have 284 of the 375 themes up on the gallery. Roughly 75%. Here is a list of the top 10 Install counts for mine.
Theme-FlatlandMonokai - 8725
Theme-Batman - 2605
Theme-Github - 2475
Theme-Dark-Dracula - 2332
Theme-azure - 2055
Theme-Monokai - 2038
Theme-Zenburn - 1833
Theme-Solarized-dark - 1765
Theme-monokai-best - 1717
Theme-OceanicNext - 1638
So, as far as mine go, could start at the top with most installs.
from editorsyntax.
Btw, I have a few insights on where VS Code themes fall short or don't look right compared to sublime.
Selected line highlight has given me huge headaches for example.
from editorsyntax.
Closing as a duplicate of #8 and because a number of the scopes have been changed since this was opened. @gravejester we should start a new discussion on scope names.
from editorsyntax.
Related Issues (20)
- its possible to implement empty coallesing operator HOT 3
- Comment Based Help Keywords and Their Parameters Not Highlighting Correctly HOT 2
- FTLOG Don't use light gray on a white background
- Powershell syntax highlighting disrupted by single quotes in HTML
- Function without arguments not colorized HOT 2
- foreach not scoped correctly after curly brace
- Asterisk is not recognized as valid function/cmdlet name character HOT 1
- Export-Member color coding issue
- Parameters are shown using variables-color HOT 7
- Version v2021.5.1 Semantic Textmate Scope is incorrect for negative numeric literals, when used as a parameter HOT 4
- No Syntax Highlighting for `enum` declarations HOT 2
- #Requires syntax highlighting bug HOT 2
- Syntax Highlighting doesn't recognize ? as part of a variable name
- Generic method type parameter support
- Syntax Highlighting: region incorrectly highlighted when defined as part of a hashtable
- Function name not recognized in definition when on different line
- word_wrap settings does not obey the global settings in sublime text HOT 1
- Attributes not attached to parameters aren't recognized as attributes but as a generic type
- Code thinks ArgumentCompleter attribute on parameter is the parameter's type
- Variables that are built-in constants are not highlighted, like `$Error` and `$PSVersionTable`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from editorsyntax.