Comments (6)
The user should also given an option to copy the link.
from milaap.
Tried working on this feature
The Web Share API doesn't support major browsers. Found it to not work on Chrome, Brave and Firefox.
Any alternatives?
@veddandekar
from milaap.
@AnupNair08
We could probably do something like, if Share API
is supported(mainly mobile browsers) then use that. If not, the use clipboard API to show the link and allow copy to clipboard instead.
This shows how we can easily add a fallback - https://css-tricks.com/how-to-use-the-web-share-api/
Our fallback could be be the much more widely supported clipboard API - https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API
from milaap.
Have a look at this: https://w3c.github.io/web-share/
- Try this on your phone, and not on a laptop
Found it over here: https://web.dev/web-share/
Documentation: https://www.w3.org/TR/web-share/
So it doesn't work on Chrome, but works on Chrome(Android)
@veddandekar @AnupNair08
from milaap.
Please check #79
Desktop users can copy link and supported browsers can use Web Share
from milaap.
Good work @AnupNair08 !
from milaap.
Related Issues (20)
- Handle app after JWT is expired HOT 3
- 'Delete Room' option to users HOT 7
- Change PWA distrideo logo to milaap Logo HOT 1
- Emoji support in chat section HOT 1
- Scroll bar in chat section if the link size exceeds 50 character
- fix: creating a new room doesnt update ui to display new room in rooms sidebar HOT 4
- fix: "Invite" option and "Create Room" option shouldn't be available for guests HOT 4
- submit screenshots if any taken HOT 3
- Enter key is not mapped correctly on Join Page HOT 1
- When user enters a room via url which does not exist, need to show an error HOT 2
- Fix : when user types msg in chat and accidentally presses enter more than 1 time, the message is sent that many times in chat HOT 5
- Remove controls on video except - Picture in Picture and Full Screen mode HOT 2
- fix: Title of the room HOT 1
- Chat section: Message Links should be active and on clicking should open in new window HOT 1
- Mobile back-camera not switching off HOT 4
- Code Cleanup + Removal of warnings HOT 1
- Refactor to move UEXIST and other error codes as non 200 statuses HOT 3
- URLs in text messages HOT 2
- Pressing <enter> refreshes the page when creating a room HOT 1
- Contributing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from milaap.