empty sourcemaps for esm bundle

[prateekbh]

empty sourcemaps for esm bundle

[prateekbh]

never mind I found the bug and opened the PR here #47

[prateekbh]

yes this is on my top priority list.
not sure whats happening here

[prateekbh]

@rickiesmooth the test would be great, however i. tested manually in this repo, the source maps looked like were being built.

but yes this would be definitely P0

[rickiesmooth]

hey @prateekbh thank you so much for looking into this! much appreciated.

I get the following results when I run npm run test on my test case branch: https://github.com/rickiesmooth/babel-esm-plugin/pull/new/bug/sourcemaps

// index.es6.js.map
{"version":3,"sources":[],"names":[],"mappings":"","file":"index.es6.js","sourceRoot":""}

// index.js.map
{"version":3,"sources":["webpack:///webpack/bootstrap","webpack:///./tests/babel-preset-modules/fixtures/index.js"],"names":["foo","a","b","args"],"mappings":";QAAA;QACA;;QAEA;QACA;;QAEA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;;QAEA;QACA;;QAEA;QACA;;QAEA;QACA;QACA;;;QAGA;QACA;;QAEA;QACA;;QAEA;QACA;QACA;QACA,0CAA0C,gCAAgC;QAC1E;QACA;;QAEA;QACA;QACA;QACA,wDAAwD,kBAAkB;QAC1E;QACA,iDAAiD,cAAc;QAC/D;;QAEA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA,yCAAyC,iCAAiC;QAC1E,gHAAgH,mBAAmB,EAAE;QACrI;QACA;;QAEA;QACA;QACA;QACA,2BAA2B,0BAA0B,EAAE;QACvD,iCAAiC,eAAe;QAChD;QACA;QACA;;QAEA;QACA,sDAAsD,+DAA+D;;QAErH;QACA;;;QAGA;QACA;;;;;;;AClFA,IAAMA,GAAG,GAAG,SAANA,GAAM;AAAA,oBAAGC,CAAH;AAAA,MAAGA,CAAH,uBAAO,CAAP;AAAA,MAAYC,CAAZ,uEAAgB,CAAhB;;AAAA,oCAAsBC,IAAtB;AAAsBA,QAAtB;AAAA;;AAAA,SAA+B,CAACF,CAAD,EAAGC,CAAH,EAAKC,IAAL,CAA/B;AAAA,CAAZ,C","file":"index.js","sourcesContent":[" \t// The module cache\n \tvar installedModules = {};\n\n \t// The require function\n \tfunction __webpack_require__(moduleId) {\n\n \t\t// Check if module is in cache\n \t\tif(installedModules[moduleId]) {\n \t\t\treturn installedModules[moduleId].exports;\n \t\t}\n \t\t// Create a new module (and put it into the cache)\n \t\tvar module = installedModules[moduleId] = {\n \t\t\ti: moduleId,\n \t\t\tl: false,\n \t\t\texports: {}\n \t\t};\n\n \t\t// Execute the module function\n \t\tmodules[moduleId].call(module.exports, module, module.exports, __webpack_require__);\n\n \t\t// Flag the module as loaded\n \t\tmodule.l = true;\n\n \t\t// Return the exports of the module\n \t\treturn module.exports;\n \t}\n\n\n \t// expose the modules object (__webpack_modules__)\n \t__webpack_require__.m = modules;\n\n \t// expose the module cache\n \t__webpack_require__.c = installedModules;\n\n \t// define getter function for harmony exports\n \t__webpack_require__.d = function(exports, name, getter) {\n \t\tif(!__webpack_require__.o(exports, name)) {\n \t\t\tObject.defineProperty(exports, name, { enumerable: true, get: getter });\n \t\t}\n \t};\n\n \t// define __esModule on exports\n \t__webpack_require__.r = function(exports) {\n \t\tif(typeof Symbol !== 'undefined' && Symbol.toStringTag) {\n \t\t\tObject.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });\n \t\t}\n \t\tObject.defineProperty(exports, '__esModule', { value: true });\n \t};\n\n \t// create a fake namespace object\n \t// mode & 1: value is a module id, require it\n \t// mode & 2: merge all properties of value into the ns\n \t// mode & 4: return value when already ns object\n \t// mode & 8|1: behave like require\n \t__webpack_require__.t = function(value, mode) {\n \t\tif(mode & 1) value = __webpack_require__(value);\n \t\tif(mode & 8) return value;\n \t\tif((mode & 4) && typeof value === 'object' && value && value.__esModule) return value;\n \t\tvar ns = Object.create(null);\n \t\t__webpack_require__.r(ns);\n \t\tObject.defineProperty(ns, 'default', { enumerable: true, value: value });\n \t\tif(mode & 2 && typeof value != 'string') for(var key in value) __webpack_require__.d(ns, key, function(key) { return value[key]; }.bind(null, key));\n \t\treturn ns;\n \t};\n\n \t// getDefaultExport function for compatibility with non-harmony modules\n \t__webpack_require__.n = function(module) {\n \t\tvar getter = module && module.__esModule ?\n \t\t\tfunction getDefault() { return module['default']; } :\n \t\t\tfunction getModuleExports() { return module; };\n \t\t__webpack_require__.d(getter, 'a', getter);\n \t\treturn getter;\n \t};\n\n \t// Object.prototype.hasOwnProperty.call\n \t__webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };\n\n \t// __webpack_public_path__\n \t__webpack_require__.p = \"\";\n\n\n \t// Load entry module and return exports\n \treturn __webpack_require__(__webpack_require__.s = 0);\n","const foo = ({ a = 1 }, b = 2, ...args) => [a,b,args];"],"sourceRoot":""}

[prateekbh]

oh great! at least its consistent 😅

[rickiesmooth]

hehe yes in that sense it's a great bug! :P

[prateekbh]

@rickiesmooth in your PR, shouldn't it be
devtool: 'source-map' instead of devtool: 'sourcemaps'?

[prateekbh]

try running this test: https://github.com/prateekbh/babel-esm-plugin/blob/source-maps/tests/source-maps/source-maps.test.js#L18

on branch source-maps

[rickiesmooth]

@prateekbh oef that's embarrassing! Sorry for sending you down that rabbit hole then. I did check the branch on the project I was working on and there I did have devtool: 'source-map' but no sourcemaps were generated, I'll investigate it some more and get back to you if I find something.

[prateekbh]

FWIW we'rer still getting the same in preact-cli so i'll keep this open

[prateekbh]

@rickiesmooth , can you try with hidden-source-maps and see if they are being generated well

[rickiesmooth]

@prateekbh great that you're looking into it! I tried hidden-source-maps on my test branch of this repo and the .es6.js.map is empty, or do you want me to try it out in my project?