Giter Site home page Giter Site logo

Comments (9)

donbowman avatar donbowman commented on September 18, 2024 1

i would recommend mounting the scripts u need as configmaps, then u can use the upstream directly.
this is how i did the helm change.
helm/charts#11343

e.g. just put the script u need in a configmap in yaml, and mount into the location u want it inside the container.

from zookeeper-operator.

spiegela avatar spiegela commented on September 18, 2024

Actually the Docker container file for emccorp/zookeeper is included within this repo. We should bump it to the 3.5 final, but it is required as it has several scripts used for custom startup, readiness and liveness checks.

from zookeeper-operator.

abh avatar abh commented on September 18, 2024

Putting scripts in configmaps sounds ... not great. Liveness and readiness checks might be able to fit in a sidecar (not the custom startup scripts though, most likely).

Maybe the official images will take patches to support the things we need here?

from zookeeper-operator.

spiegela avatar spiegela commented on September 18, 2024

Another option would be to add an initContainer that populates the /data volume with the required scripts and the zu utility. @EronWright Do you have an opinion on this?

from zookeeper-operator.

EronWright avatar EronWright commented on September 18, 2024

From an OSS perspective, it does seem good to use the stock image. I don't know enough about the scripts to have a strong opinion. The sidecar pattern is highly useful for liveness checks, as mentioned above. I would strive for that if possible.

from zookeeper-operator.

AceHack avatar AceHack commented on September 18, 2024

We would like to see this, any new thoughts on using this?

from zookeeper-operator.

fpj avatar fpj commented on September 18, 2024

Note that the "official" image is not an image produced by the Apache community, see for example the "where to file issues" line:

https://github.com/31z4/zookeeper-docker/issues

from zookeeper-operator.

fpj avatar fpj commented on September 18, 2024

We are also not pushing images to emccorp on docker hub, we are pushing them under pravega:

https://hub.docker.com/repository/docker/pravega/zookeeper-operator

Is this issue still valid?

from zookeeper-operator.

anishakj avatar anishakj commented on September 18, 2024

Closing this issue as it is invalid.

from zookeeper-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.