NSFW issues

[praw-dev]

NSFW issues

[marblar]

I'll take a look at this over the weekend.

[bboe]

@marblar cool. What's the python 3 status? Should I start to integrate it?

[marblar]

@bboe It's getting there. I have a bug or two to sort out, and then I want to do some clean up before we start integrating. If you want to take a look at the current state and make sure I'm headed in the right direction, you're welcome to.

[marblar]

I was able to iterate through /r/nsfw without modification. Do you have any code to recreate the issue?

[bboe]

Well it seems like it is not a problem for a non-authenticated user. However, if you provide a user, the user must have the over18 setting enabled. We should raise a ClientException when the 403 restricted error occurs (if that's the only case of that error and it's the right one).

[bboe]

So there are some inconsistencies in the API with respect to the over18 setting. These being:

• Non-authenticated users could access NSFW subreddit listings and submissions
• Authenticated users who do not have the over18 setting enabled received empty NSFW subreddit listings but could access the NSFW submissiosn fine

After a brief chat with @spladug it seems ignoring the NSFW setting for API users is the simplest route to take, compared to the alternative which is to add an API error for attempting to access NSFW content when over18 is not enabled.

Waiting on reddit-archive/reddit#402 to go through.

[bboe]

NSFW is no longer an issue for the API. reddit-archive/reddit@07d8675