Comments (8)
@ralphtheninja I meant this behavior.
from prebuild-install.
No, this is currently not possible. The standalone check was implemented as a little help for the module developers, so they don't have to specify --build-from-source
every time they want to build their modules.
@ralphtheninja I see two options here:
- remove the standalone path (major)
- add a new argument for this case like
--force-download
that skips the standalone check (minor).
I am tending to 1 because prebuild-install
was made to download the binary. And it should only exit if a user don't want to or a download is not possible. And for developer there are still two aliases for --build-from-source
--compile
and -c
wich should be documented :)
from prebuild-install.
I need to convince prebuild-install to not download and not error, or convince node-gyp to not build if it gets run.
I was a bit confused by this. If I understand correctly, you want prebuild-install
to download and if that fails it should fail?
How about adding prebuild-install --test
instead, you could then have a pretest
script that's being run when testing (or add another script and execute it explicitly in e.g. .travis.yml)
@mathiask88 What do you mean with "the standalone path"?
from prebuild-install.
I think the --test
flag would need to process.exit(0)
to prevent the binary from being built from node-gyp
with the recommended setup.
Unless --test
would be used for testing to see if it could download the package and not actually installing the binary?
I'd prefer to keep this in the install processes so I can verify that not only it downloaded but the download works.
eg
npm install --prebuild-test
node ./ # Would fail if binary isn't present
Funny enough this works on linux, false
takes any argument and fails
node-gyp rebuild --make=false
but I don't know how to pass it through npm install
from prebuild-install.
Oh, ok I misread. I thought you want to download the binary in your dev environment, ignore my last answer then :)
from prebuild-install.
Oh, ok I misread. I thought you want to download the binary in your dev environment, ignore my last answer then :)
This is my current understanding as well :)
from prebuild-install.
@reconbot Is this still a thing?
from prebuild-install.
Yeah, unless there's been new features I don't know about. This allows me to test our build pipeline and ensure we have binaries published and useable without having to build something to test prebuild-install.
from prebuild-install.
Related Issues (20)
- Resolve vulnerabilities in dependencies (npmlog>gauge>ansi-regex) HOT 4
- Remove `rc` dependency HOT 2
- Version bump of `npmlog` HOT 1
- Resolve CVE-2022-0355 by upgrading to simple-get 4.0.1+ HOT 1
- Update simple-get to 4.0.1 HOT 1
- Resolve vulnerability in dependencies (simple-get < 4.0.1) HOT 1
- Please update simple-get dependency to resolve security issue. HOT 1
- npm_config_* variables are not available in npm v7+ which breaks prebuild platform overrides HOT 3
- prebuild-install can't install node-canvas prebuild HOT 1
- CVE-2021-44906: Minimist <=1.2.5 is vulnerable to Prototype Pollution HOT 2
- Can't install package in private network HOT 4
- How to disable enforced compilation? HOT 1
- Mirroring with custom host much harder compared with node-pre-gyp
- [CVE-2022-0355] Exposure of Sensitive Information to an Unauthorized Actor in NPM simple-get prior to 4.0.1 HOT 5
- Expired certificate HOT 2
- prebuild-install not found HOT 2
- prebuild-install WARN install No prebuilt binaries found HOT 1
- Critical CVE reported in latest ([email protected]) HOT 2
- prebuild-install will mutate the contents of an hard-linked `.node` file
- why doesn't it honor NPM_CONFIG_CACHE? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prebuild-install.