Comments (10)
The "skipping download" thing is a feature used for when developing modules. But in your case this feature gets in your way since you are actually using git: or file: based dependencies and you will basically never get any prebuilts.
This case also falls under "development". A git based dependency is mutable, so it can't have prebuilds.
Why don't you make a PR to make https://github.com/santigimeno/node-pcsclite prebuild ready? Maybe you can convince him that using prebuild is a cool thing? :)
👍
from prebuild-install.
If a binary is available prebuild-install
will always use it. Compiling from source is fallback only on user side. Do you have an example?
from prebuild-install.
Sorry, yes. To clarify, I am attempting to use prebuild while installing a node module from a Git(Hub) repository instead of NPM. If I do not install the module directly from NPM (the original module does not provide prebuilt binaries) then I receive a line like the following:
> prebuild-install || node-gyp rebuild
prebuild-install info begin Prebuild-install version 2.3.0
prebuild-install info install installing from git repository, skipping download.
I have not found any way to force the use of prebuilt binaries, despite both trying with binaries commited in prebuilds
and with prebuild's native prebuild -u <token>
GitHub release upload. If there is a way to do so already, we can update the documentation to make this clearer.
Just to clarify, the module is included as a dependency under git+<repository>
/file:<path>
, but both methods cause it to skip retrieval of the (most certainly available) prebuilt binaries.
from prebuild-install.
I think I know what you mean now. The "skipping download" thing is a feature used for when developing modules. But in your case this feature gets in your way since you are actually using git:
or file:
based dependencies and you will basically never get any prebuilts. Correct?
from prebuild-install.
Why don't you make a PR to make https://github.com/santigimeno/node-pcsclite prebuild ready? Maybe you can convince him that using prebuild is a cool thing? :)
from prebuild-install.
This case also falls under "development". A git based dependency is mutable, so it can't have prebuilds.
True.. The only thing we could do is to check if the github url is a tagged one and search the releases for that tagged version?!
from prebuild-install.
I think I know what you mean now. The "skipping download" thing is a feature used for when developing modules. But in your case this feature gets in your way since you are actually using git: or file: based dependencies and you will basically never get any prebuilts. Correct?
This is correct.
Why don't you make a PR to make https://github.com/santigimeno/node-pcsclite prebuild ready? Maybe you can convince him that using prebuild is a cool thing? :)
Strange, I don't recall mentioning that module? ;)
Unfortunately, that would only solve our most obvious issue: getting the module itself loaded. We have a multi-stage build process for a cross-platform app that, ideally, should only have to be run on a Linux machine. Amongst various other issues, we want to make certain we're using our QA-tested binaries.
This case also falls under "development". A git based dependency is mutable, so it can't have prebuilds.
True.. The only thing we could do is to check if the github url is a tagged one and search the releases for that tagged version?!
I don't think changing the default behavior here is worth the effort; instead, I would propose a new flag that forces prebuild-install
to ignore those checks. If accidental developer misuse is a worry, we could add warnings to alert the developer.
The code looks simple enough to modify. If there's not an existing method to do this, then I'll work on a pull request to add this functionality? :)
from prebuild-install.
The code looks simple enough to modify. If there's not an existing method to do this, then I'll work on a pull request to add this functionality? :)
👍
from prebuild-install.
@ralphtheninja The PR has been made when you have the chance to review it.
from prebuild-install.
@ian-axiadids Yep, just noticed it! Fixing borked travis first.
from prebuild-install.
Related Issues (20)
- Resolve vulnerabilities in dependencies (npmlog>gauge>ansi-regex) HOT 4
- Remove `rc` dependency HOT 2
- Version bump of `npmlog` HOT 1
- Resolve CVE-2022-0355 by upgrading to simple-get 4.0.1+ HOT 1
- Update simple-get to 4.0.1 HOT 1
- Resolve vulnerability in dependencies (simple-get < 4.0.1) HOT 1
- Please update simple-get dependency to resolve security issue. HOT 1
- npm_config_* variables are not available in npm v7+ which breaks prebuild platform overrides HOT 3
- prebuild-install can't install node-canvas prebuild HOT 1
- CVE-2021-44906: Minimist <=1.2.5 is vulnerable to Prototype Pollution HOT 2
- Can't install package in private network HOT 4
- How to disable enforced compilation? HOT 1
- Mirroring with custom host much harder compared with node-pre-gyp
- [CVE-2022-0355] Exposure of Sensitive Information to an Unauthorized Actor in NPM simple-get prior to 4.0.1 HOT 5
- Expired certificate HOT 2
- prebuild-install not found HOT 2
- prebuild-install WARN install No prebuilt binaries found HOT 1
- Critical CVE reported in latest ([email protected]) HOT 2
- prebuild-install will mutate the contents of an hard-linked `.node` file
- why doesn't it honor NPM_CONFIG_CACHE? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prebuild-install.