Giter Site home page Giter Site logo

Comments (6)

presidentbeef avatar presidentbeef commented on May 22, 2024

Yeah, it's ruby parser. I did some minor monkeypatching to help it out, but it's not enough. Hopefully there will be a release with 1.9 syntax support soon. I've considered vendoring it, but it seems like a pain.

On the other hand, I think it's silly that Rails will generate 1.9 syntax if you happen to use 1.9 and 1.8 syntax otherwise. Kind of a weird thing to do.

from brakeman.

oreoshake avatar oreoshake commented on May 22, 2024

Yeah that's like when you see a hash like:

asdf = {:something => 'asdf', asdf: 'something'} wtf

Justin wrote:

Yeah, it's ruby parser. I did some minor monkeypatching to help it
out, but it's not enough. Hopefully there will be a release with 1.9
syntax support soon. I've considered vendoring it, but it seems like a
pain.

On the other hand, I think it's silly that Rails will generate 1.9
syntax if you happen to use 1.9 and 1.8 syntax otherwise. Kind of a
weird thing to do.


Reply to this email directly or view it on GitHub:
#20 (comment)

from brakeman.

presidentbeef avatar presidentbeef commented on May 22, 2024

Okay, I have a local copy of ruby_parser working with Brakeman, and it parses the Rails 3 generated files. Need to test some more to make sure I don't run into problems with the gem version.

Edit: I mean the ruby_parser gem will be installed because of dependencies that Brakeman has. I need to make sure the gem does not get loaded and cause conflicts with the local version.

from brakeman.

presidentbeef avatar presidentbeef commented on May 22, 2024

Okay, this should be all fixed now. Thanks!

from brakeman.

oreoshake avatar oreoshake commented on May 22, 2024

Confirmed. Thanks!

Justin wrote:

Okay, this should be all fixed now. Thanks!


Reply to this email directly or view it on GitHub:
#20 (comment)

from brakeman.

samstickland avatar samstickland commented on May 22, 2024

+1

from brakeman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.