Giter Site home page Giter Site logo

Comments (12)

zimme avatar zimme commented on June 3, 2024 4

I was able to install changeset-bot to this repo and prettier-eslint and you've been added to the npm packages too @JounQin.

from prettier-eslint-cli.

kylemh avatar kylemh commented on June 3, 2024 1

i vote yes since:

  1. you're flying and I don't want to get in your way.
  2. i don't care as long as we stick to mostly semantic versioning and it's easy for all of us to know how to cut releases.

from prettier-eslint-cli.

zimme avatar zimme commented on June 3, 2024 1

@kylemh @idahogurl feel free to give me your npm usernames and I can add you to the npm package as admins so you can generate new keys if that's needed for this change

from prettier-eslint-cli.

JounQin avatar JounQin commented on June 3, 2024 1

@idahogurl

your commit message will cause a bump. I'm going to switch my extension repo's to use it.

It's not how changesets work, changesets are based on changesets files, not commit message. We're about to control the whole release flow before we finally merge the PR created by action-bot.

from prettier-eslint-cli.

JounQin avatar JounQin commented on June 3, 2024

@kylemh @idahogurl Shall we move forward?

I found semantic-release is bad again in the case that I want to introduce two breaking changes in one major version, it is impossible for semantic-release or we have to trick it. It is very unnatural and ridiculous.

from prettier-eslint-cli.

idahogurl avatar idahogurl commented on June 3, 2024

I'm good with changing it since it is causing headaches. @JounQin I liked @kylemh suggestion of using https://intuit.github.io/auto/. Marking PRs with labels is way easier than making sure your commit message will cause a bump. I'm going to switch my extension repo's to use it.

from prettier-eslint-cli.

kylemh avatar kylemh commented on June 3, 2024

so it sounds like, just take your pick @JounQin and fire away.

from prettier-eslint-cli.

kylemh avatar kylemh commented on June 3, 2024

kylemh on NPM as well. I think you should add @JounQin if you haven't already, too. He's extremely involved in multiple large open source organizations.

from prettier-eslint-cli.

idahogurl avatar idahogurl commented on June 3, 2024

Mine is idahogurl99. Agree with @kylemh about adding @JounQin

from prettier-eslint-cli.

JounQin avatar JounQin commented on June 3, 2024

I'm very familiar with changesets, but lack of experience of auto.

Do you really release every pull request?!

Yup! But if you don't want to do that it's up to you. The tools auto ships with can be used to fit any workflow! You can also use skip-release labels or configure auto to only release with a release label.

I can imagine headaches about forget adding tags. 😅 No way to add change later and confirm with a PR like changesets.

So I still vote for changesets.

from prettier-eslint-cli.

JounQin avatar JounQin commented on June 3, 2024

@zimme Thanks, my npm account username is jounqin.

from prettier-eslint-cli.

JounQin avatar JounQin commented on June 3, 2024

@zimme Do you have permissions to install changeset-bot?

from prettier-eslint-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.