Giter Site home page Giter Site logo

Comments (16)

melloware avatar melloware commented on June 10, 2024 2

OK man this was a lot of hacking but I think I got everything working with the latest PDF.js: 2.9.35.

I published a 10.0.5-SNAPSHOT of PFE if you want to give it a try...

You will need this in your pom.xml to reach the Sonatype Snapshots...

<repository>
    <id>sonatype-snapshots</id>
    <name>Sonatype Snapshot Repository</name>
    <url>https://s01.oss.sonatype.org/content/repositories/snapshots</url>
    <releases>
        <enabled>false</enabled>
    </releases>
    <snapshots>
        <enabled>true</enabled>
    </snapshots>
</repository>

from primefaces-extensions.

melloware avatar melloware commented on June 10, 2024 1

@ivy-cst thanks for reporting. Yuck! Upgrading this library is quite difficult and since we use it in an IFRAME the last time I tried to upgrade it the Font would not appear. I will put this on my list to try and upgrade.

from primefaces-extensions.

melloware avatar melloware commented on June 10, 2024 1

We are a small project here so I typically don't backport fixes to older versions and publish them to central. We typically just always work on the latest version but as you saw patching it yourself is not too bad.

from primefaces-extensions.

melloware avatar melloware commented on June 10, 2024 1

Anyone watching this ticket this is now in Maven Central as 10.0.5

from primefaces-extensions.

Cantfirmed avatar Cantfirmed commented on June 10, 2024

When is the next update planned? I would do it myself but the changes.txt for documentviewer is outdated.

from primefaces-extensions.

melloware avatar melloware commented on June 10, 2024

When I tried last time to upgrade the issue i mentioned above was still happening causing the font to be messed up. I know they did a release recently but I haven't tried to upgrade it.

Is there some feature you need that is not in the current PDF viewer?

from primefaces-extensions.

Cantfirmed avatar Cantfirmed commented on June 10, 2024

Some browsers (eg. Firefox, IE) have problems with visible digital signatures. They get removed in the online viewer and they are also removed if you download them. I tested it with the newest pdf.js where it now works to display the signatures correctly.

from primefaces-extensions.

melloware avatar melloware commented on June 10, 2024

OK let me know because they previously had not supported digital signatures.

from primefaces-extensions.

Cantfirmed avatar Cantfirmed commented on June 10, 2024

They now show them but the signatures are not validated.
mozilla/pdf.js#13214

from primefaces-extensions.

melloware avatar melloware commented on June 10, 2024

Looks like that feature its not in an official release yet as latest released was 2.8.335 on Apr 5 and this was merged on April 10th.

from primefaces-extensions.

melloware avatar melloware commented on June 10, 2024

And you are right the structure of PDF.JS has changed significantly so our old upgrade instructions are completely irrelevant

from primefaces-extensions.

Cantfirmed avatar Cantfirmed commented on June 10, 2024

Looks like that feature its not in an official release yet as latest released was 2.8.335 on Apr 5 and this was merged on April 10th.

Ah, true that's my bad. I just cloned the repo and forgot to check the actual releases. The feature is already in the pre-release but I guess you want to wait for the actual release?

from primefaces-extensions.

melloware avatar melloware commented on June 10, 2024

I spent about an hour trying to upgrade to v2.9.359 and it is fighting me. Feel free to take a crack at it...i will gladly accept a PR.

from primefaces-extensions.

ivy-cst avatar ivy-cst commented on June 10, 2024

We have the same bug as here: wojtekmaj/react-pdf#819.
With Chrome 92 and up some pdf's are not rendered correctly with the current included pdf.js.
The upgrade to pdf.js v2.9.359 would fix our problems.

from primefaces-extensions.

ivy-cst avatar ivy-cst commented on June 10, 2024

OK man this was a lot of hacking but I think I got everything working with the latest PDF.js: 2.9.35.

I published a 10.0.5-SNAPSHOT of PFE if you want to give it a try...

You will need this in your pom.xml to reach the Sonatype Snapshots...

<repository>
    <id>sonatype-snapshots</id>
    <name>Sonatype Snapshot Repository</name>
    <url>https://s01.oss.sonatype.org/content/repositories/snapshots</url>
    <releases>
        <enabled>false</enabled>
    </releases>
    <snapshots>
        <enabled>true</enabled>
    </snapshots>
</repository>

Thank you very much. Great job. Works now with newest browsers. Would it be possible to patch that down to 7.0.x and 8.0.x? I patched 7.0.3 (the version we currently use) by hand and it did also work.

from primefaces-extensions.

melloware avatar melloware commented on June 10, 2024

I also just backported this and released PFE 8.0.5

from primefaces-extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.