Showcase: RemoteCommand parameter examples do not work using JDK 11

[primefaces-extensions]

Showcase: RemoteCommand parameter examples do not work using JDK 11

[GedMarc]

guys no it is not an issue
LocalDate and Instant have changed between JDK 8 and JDK 9 and up, you have to change your code (or use META-INF/versions), The precision for deserialization and serialization (0..9fractional nano) as well

https://blog.joda.org/2017/02/java-time-jsr-310-enhancements-java-9.html

Further more - locale's are not really enabled anymore by default, especially in module mode, so keep an eye out for that :

this is by design

[melloware]

I will investigate.

[melloware]

I wonder if it is locale related? I am running it locally and its working fine for me? My browser is English United States locale since I live in the US.

[jepsar]

My browser is also set to US English as the default (I prefer it over Dutch online)... weird though that it works in production for me.

[melloware]

So is it failing on localhost for you in the latest showcase?

[jepsar]

Yes, I assumed it was caused something changed in the showcase recently.

[melloware]

I wonder if its a JDK issue with short format?

<f:convertDateTime type="both" dateStyle="short" locale="en"/>

I am using JDK8.

[jepsar]

Ah, I'm on 11 by default. Let me see if it works with 8.

[melloware]

We have seen this before with JDK11: primefaces/primefaces#5696

[jepsar]

It's indeed an issue with JDK 11.

[jepsar]

@GedMarc Yes, I meant that the issue in the showcase only occurs when the showcase is run with JDK 11. Thanks for pointing that out though. @melloware does this require any action? PF targets JDK 8, right?

[tandraschko]

PF targets all versions IMO but LTS for sure (8, 11, 15/16?)

[GedMarc]

8 / 11 /17 ?

I'm running PF on JDK 14 JLink build here (Mojarra 'ish) https://pfshowcase.guicedee.com/
I'll see if i can replicate and resolve, it will definitely need a multi-version jar though, you guys ok with that?

[GedMarc]

mmm, please assist in replication - can't seem to or i've fixed in somewhere on my side already (will make the pr easier..)

[melloware]

You can read the whole thread or check out @christophs78 debugging the problem: primefaces/primefaces#5696 (comment)

and since this conversion is happening inside f:convertDateTime its counting on the JDK to be correct.

Especially if you use Locale en_GB in OpenJDK 11 you will see the issue.

[melloware]

For now I just fixed the examples to work in JDK8 or 11+