Giter Site home page Giter Site logo

Comments (8)

melloware avatar melloware commented on July 22, 2024

I think when we had talked before we left it in there for people still using it but we removed the showcase examples so people would stop using it. Basically it's there just for backward compatibility from what I remember. 🤷🏻‍♂️

from primefaces.

martin654 avatar martin654 commented on July 22, 2024

Hi, we are still using it in production. I don't think that it could be replaced by other DataTable features (we use it with lazy and pagination).

from primefaces.

Rapster avatar Rapster commented on July 22, 2024

I understand that, but also understand that so far, the way I see it, it feels we're maintening 2 features wich does the very same thing and I could be 100% wrong, but I asked in the past whoever using that feature to give us a reproducer which shows row grouping can't replace subtable and nothing...

If that turns out to be true, then we should update our docs, and our showcase. Do you think you could make a reproducer of how you're using subtable?

from primefaces.

martin654 avatar martin654 commented on July 22, 2024

I will try to find time to create reproducer

from primefaces.

Rapster avatar Rapster commented on July 22, 2024

Ok got it, if I understand well that coment #2269 (comment) It's useful in case of one-to-many association (non flat model) but because you "can't" change that into a flat model, you have no other choice than use subTable right?

Also, do features like sorting/filtering/exporting works on subtable?

from primefaces.

martin654 avatar martin654 commented on July 22, 2024

Great that you found the old comment with the explanation. Yes, the data provided by backend are not flat, but structured with one-to-many association. We are not able to change existing backend impl just because some feature is deprecated in frontend component.

Well, good question... We use just the lazy loading and pagination feature in this case. We use filtering in this case too, but it is placed above the table in "Filtering panel", not in column headers. And the filter data are filled into service request in lazy load method.

Edit:
I think that there is a big difference when pagination used. With one-to-many association you paginate accross the master records, so for 10 items per-page you have 10 master records and all their childs on the first page.
With flat structure you would see first 10 items. It could be subset of first master record childs or you could see childs from multiple master records. It depends on the counts of childs. And its unpredictable.

Example with paginator set to 10 items per page:
Imagine a dataset in backend with 11 master items and each of them having 15 childs.
With subtable you would see first page with 10 master items and each master item would have all 15 child items displayed.
If you flatten the structure in backend and use rowgroup, you would see first 10 items from "first master".
Can you feel the difference?

from primefaces.

Rapster avatar Rapster commented on July 22, 2024

I'm okay to undeprecate subTable, we should put the showcase pages back, remove deprecated logs etc.

from primefaces.

melloware avatar melloware commented on July 22, 2024

OK i will take care of that!

from primefaces.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.