Can we remove p:resetInput?

[tandraschko]

Can we remove p:resetInput?

[DazzlingBob]

I'm not in favor of removing p:resetInput.
The following construction is used a lot in our projects :

<p:commandLink title="Title"
  action="#{bean.doAction(data)}"
  update=":mainform:tabContainer:container :mainform:containerA :mainform:containerB :mainform:containerC"
  rendered="#{not empty data.id}"
  process="@this">
  <p:resetInput target=":mainform:tabContainer:container" />
</p:commandLink>

Only inputs in :mainform:tabContainer:container are reset.
Other containers like :mainform:containerA keep there input values, in our case often input search criteria with the search result as text. The search result can change though database transactions/bean.doAction.

The official JSF 2.2 definition of resetValues="true" is: "JSF resets all input components specified in the render attribute."
For example: <f:ajax render="field1" resetValues="true"/>

So:

<p:commandLink title="Title"
  action="#{bean.doAction(data)}"
  update=":mainform:tabContainer:container :mainform:containerA :mainform:containerB :mainform:containerC"
  rendered="#{not empty data.id}"
  process="@this"
  resetValues="true">
</p:commandLink>

Means all inputs of containers mentioned in "update" (in JSF: the render tag) will reset.
What is not correct in this situation.

When the tag p:resetInput is removed the only solution is to add in method bean.doAction:

PrimeFaces.current().resetInputs(":mainform:tabContainer:container");

Which is correct, but is less semantic/visible then a p:resetInput tag.

[melloware]

@tandraschko i will have to check but we do this a lot to reset a Dialog before opening it which lives in another form.

<p:commandButton id="btnAdd" actionListener="#{pathDefinitionController.newEntity()}"
				value="#{appmsg['action.admin.add']}" title="#{appmsg['action.admin.add.hint']}" icon="fa fa-plus"
				styleClass="ui-admin-button" rendered="#{accessProvider.adminOwner}" immediate="true" update=":frmEntityDialog"
oncomplete="PF('editDialog').show();">
	<p:resetInput target=":frmEntityDialog" />
</p:commandButton>

I wasn't sure resetValues="true" handles this case so I guess we need to test it. cc @FlipWarthog

[tandraschko]

in your case you can just remove p:resetInput and add resetValues=true, should work

[melloware]

OK we will test it and report back.

[DazzlingBob]

What about a programmatically reset like "PrimeFaces.current().resetInputs("form:panel")"?
Very unfortunate if that is not possible anymore.

[melloware]

What about a programmatically reset like "PrimeFaces.current().resetInputs("form:panel")"? Very unfortunate if that is not possible anymore.

@DazzlingBob no i think its just removing the tag <p:resetInput> all else would remain i believe.

[tandraschko]

Yeah
Only the tag

[melloware]

I think we also do that @DazzlingBob which is why now i remember using p:resetInout to control only what gets reset not what gets also Updated.

[tandraschko]

sounds valid
lets close