Giter Site home page Giter Site logo

Comments (11)

Rene-Stoeckel avatar Rene-Stoeckel commented on September 27, 2024 1

Thank you very much for the quick response. We tried this tester and the two issues are fixed. Screenreader, cursor navigation and column auto resize are as expeced.

from primefaces.

melloware avatar melloware commented on September 27, 2024

@Rene-Stoeckel just for reference what are the keyboard shortcuts in Excel to do this?

from primefaces.

Rene-Stoeckel avatar Rene-Stoeckel commented on September 27, 2024

@Rene-Stoeckel just for reference what are the keyboard shortcuts in Excel to do this?
In Excel its just a navigation through the menus using ALT->H->O->I (in german ALT->R->FF->I).
https://www.launchexcel.com/column-width-autofit-keyboard
It should be something simpler, like ALT+W etc.

from primefaces.

melloware avatar melloware commented on September 27, 2024

Oh you want it to Auto Adjust the width of the column.

from primefaces.

melloware avatar melloware commented on September 27, 2024

This is not trivial, I think this would require:

  1. For the current column that has focus, find the longest text in the column by walking all the cells.
  2. For that text try and determine a "visible pixel size" based on the current font size etc.
  3. Change the current column width to be that new calculated "visible pixel size".

from primefaces.

melloware avatar melloware commented on September 27, 2024

@Rene-Stoeckel please have your team test out this reproducer:
pf-11918.zip

Unzip and run mvn clean jetty:run and navigate to: http://localhost:8080/

Now when you are in a column and press ALT+W it resizes teh column to fit the largest element.

datatable-resizer

from primefaces.

Rene-Stoeckel avatar Rene-Stoeckel commented on September 27, 2024

We just tested this reproducer with the screenreader and we can confirm that

  1. the content of the table is correctly presented with the screenreader, just as expected.
  2. cursor navigation is working as expected,
  3. the column size can be adjusted as expected with ALT-W.

But there are things we noticed that still must be fixed here:

  1. When the fokus is on cell top left (1,1) and a cell different from (1,1) is clicked with the mouse then the cursor navigation is broken. The fokus travels to a different cell than expected and some cells can no longer be reached. E.g. click on the cell "New York", navigate all way down and then all way up (cursor down/up or page down/up) and the fokus will end up in cell 123.
  2. The auto resize of a column should also consider the length of the text of its column header including the icon so that the header would be fully visible after resize as well.

from primefaces.

melloware avatar melloware commented on September 27, 2024

@Rene-Stoeckel for issue 1 can you reproduce it exactly? or give me instructions on how to reproduce the issue?

as for Issue 2 let me see what I can do.

from primefaces.

Rene-Stoeckel avatar Rene-Stoeckel commented on September 27, 2024

I updated the description of finding 1) in the comment above to be more specific. Browsers I used are chrome 124 and MS edge 124.

from primefaces.

melloware avatar melloware commented on September 27, 2024

OK I think I fixed both issues if you want to try this one. Don't forget to CTRL+F5 to reload JS.
pf-dt-accessibility.zip

from primefaces.

melloware avatar melloware commented on September 27, 2024

OK i will put a PR together to get this incorporated into PF. Thank you for the detailed testing!

from primefaces.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.