Comments (11)
Thank you very much for the quick response. We tried this tester and the two issues are fixed. Screenreader, cursor navigation and column auto resize are as expeced.
from primefaces.
@Rene-Stoeckel just for reference what are the keyboard shortcuts in Excel to do this?
from primefaces.
@Rene-Stoeckel just for reference what are the keyboard shortcuts in Excel to do this?
In Excel its just a navigation through the menus using ALT->H->O->I (in german ALT->R->FF->I).
https://www.launchexcel.com/column-width-autofit-keyboard
It should be something simpler, like ALT+W etc.
from primefaces.
Oh you want it to Auto Adjust the width of the column.
from primefaces.
This is not trivial, I think this would require:
- For the current column that has focus, find the longest text in the column by walking all the cells.
- For that text try and determine a "visible pixel size" based on the current font size etc.
- Change the current column width to be that new calculated "visible pixel size".
from primefaces.
@Rene-Stoeckel please have your team test out this reproducer:
pf-11918.zip
Unzip and run mvn clean jetty:run
and navigate to: http://localhost:8080/
Now when you are in a column and press ALT+W
it resizes teh column to fit the largest element.
from primefaces.
We just tested this reproducer with the screenreader and we can confirm that
- the content of the table is correctly presented with the screenreader, just as expected.
- cursor navigation is working as expected,
- the column size can be adjusted as expected with ALT-W.
But there are things we noticed that still must be fixed here:
- When the fokus is on cell top left (1,1) and a cell different from (1,1) is clicked with the mouse then the cursor navigation is broken. The fokus travels to a different cell than expected and some cells can no longer be reached. E.g. click on the cell "New York", navigate all way down and then all way up (cursor down/up or page down/up) and the fokus will end up in cell 123.
- The auto resize of a column should also consider the length of the text of its column header including the icon so that the header would be fully visible after resize as well.
from primefaces.
@Rene-Stoeckel for issue 1 can you reproduce it exactly? or give me instructions on how to reproduce the issue?
as for Issue 2 let me see what I can do.
from primefaces.
I updated the description of finding 1) in the comment above to be more specific. Browsers I used are chrome 124 and MS edge 124.
from primefaces.
OK I think I fixed both issues if you want to try this one. Don't forget to CTRL+F5 to reload JS.
pf-dt-accessibility.zip
from primefaces.
OK i will put a PR together to get this incorporated into PF. Thank you for the detailed testing!
from primefaces.
Related Issues (20)
- Remove locales JS from datepicker showcase
- Auto detect HTML5_COMPLIANCE HOT 5
- Sticky: Filtering column in p:dataTable/p:column, using sticky feature, do not allow user input. Must use scrolling to activate HOT 10
- Showcase: Error when running locally after a few minutes HOT 14
- FileUpload component has dependency on Apache POI HOT 1
- OverlayPanel: Memory Leak on destroy HOT 1
- TabView: Memory leak on Tab close
- ImportConstants/ImportEnum: Preserve order of constants HOT 1
- Barcode: default QR code size HOT 7
- Primefaces V14 - p:fileUpload drag/drop no triggers listener HOT 2
- CascadeSelect: unable to scroll with large number of items HOT 1
- IT: Nightly Build DatePicker012Test failing Chrome HOT 3
- Showcase: v8 errors on all pages HOT 7
- FileUpload: Unsupported Content-Type [application/x-www-form-urlencoded; charset=UTF-8], expected [multipart/form-data] HOT 2
- Rating: required="true" not working HOT 9
- BlockUI: Interferes with the CSS position of target elements HOT 10
- Columns: sortFunction fails HOT 1
- Rating: Resubmit after invalid sets value to 3
- monitorDownload: not working in Chrome with ajax=false and non-secure Cookies, due to SameSite=None HOT 6
- DataTable: p:link does not work when used in a p:column HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primefaces.