Giter Site home page Giter Site logo

Add padding to CodeExample about blueprints HOT 4 CLOSED

primer avatar primer commented on May 3, 2024
Add padding to CodeExample

from blueprints.

Comments (4)

simurai avatar simurai commented on May 3, 2024

Another cool thing and I remember chatting with @shawnbot about it. Being able to "pass in" any class or maybe even inline styles through the code fence declaration.

  ```html class="text-center" style="min-height: 100px;"
  <details>

Would output:

<iframe>
  ...
  <div class="p3 text-center" style="min-height: 100px;">
    <details>

This would allow us to hide the "setup" styles from code examples. And avoid being copy&pasted by mistake.

from blueprints.

emplums avatar emplums commented on May 3, 2024

@simurai can you remind me where you saw this bug popping up again?

from blueprints.

simurai avatar simurai commented on May 3, 2024

On the Primer CSS buttons page, after clicking on a button, the "blue focus" outline should be visible:

Actual Expected
Screen Shot 2019-06-03 at 10 38 39 AM Screen Shot 2019-06-03 at 10 40 03 AM

Another example is the Label--outline on the Primer CSS labels page. They seem to have a negative top/bottom margin:

image

Which hides the top/bottom border when in an iframe.

Actual Expected
Screen Shot 2019-06-03 at 10 44 58 AM Screen Shot 2019-06-03 at 10 45 44 AM

from blueprints.

shawnbot avatar shawnbot commented on May 3, 2024

@simurai I'd like to look at the fenced code blocks prop passing today. IIRC it's a pretty simple tweak.

from blueprints.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.