Comments (6)
@mperrotti do you have availability to take this on?
from components.
Button with variant=inivisble has the same foreground color as variant=outline and no disabled state
@mattcosta7 - I see a disabled state on when testing <Button variant="invisible" disabled>Test</Button>
. The only inconsistency I'm seeing is the foreground color.
Here's the PR: #3368
from components.
Button with variant=inivisble has the same foreground color as variant=outline and no disabled state
@mattcosta7 - I see a disabled state on when testing
<Button variant="invisible" disabled>Test</Button>
. The only inconsistency I'm seeing is the foreground color.Here's the PR: #3368
That sounds about right
from components.
@tallys do you want to see if a designer is available to take a look at this?
from components.
@mperrotti we may need to open this up to a larger discussion about the invisible
variant, but the idea is that the foreground color is only link blue for Button
if there are no visuals present as demonstrated here. And IconButton
is never link blue. There was recent discussion in Slack about this too.
outline
variant is being deprecated, and then there's the link
variant which is also confusing. Long long ago I proposed making the API overly verbose for buttons styled as links to better differentiate between the invisible
variant and a link
variant.
Anyways, should we open a discussion? Still worth fixing the disabled state mentioned in this issue.
from components.
Yes @langermank - fully agree that we should open a discussion. Would you like to start the discussion? or should I?
from components.
Related Issues (20)
- Active `NavList.Item` is incorrectly missing bold styling HOT 4
- The theme object inflates bundle size. HOT 1
- Release Tracking
- The `useAnchoredPosition` hook returns generic refs for Element, which always requires a type assertion by the user
- TreeView: Remove aria-describedby when leading and trailing visuals do not exist HOT 2
- Does the Primer Design System have card components or similar card-like components? HOT 1
- Release Tracking HOT 1
- TreeView: Add support for external styling HOT 3
- TexInput `onClick` focus behavior broken with `type=date` on Safari
- `Dialog` should allow wrapping content, header, and footer (for example in `Suspense` or some context) HOT 2
- Utils should be exported
- Tests: Remove redundant ThemeProvider from tests
- `DialogV2` has incorrect names for width values HOT 1
- Enhancement: Add support for flush action lists HOT 2
- Update docs for `Button` to not consider `count` as required HOT 1
- Release Tracking
- Using `TooltipV2` always sets aria associations on first child element HOT 11
- [Tests] Ensure that axe calls are made on open state of the component HOT 4
- [TreeView] Add area for `dragHandle` to be shown before the expand/collapse toggle HOT 1
- Release Tracking
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from components.