Giter Site home page Giter Site logo

Comments (6)

tallys avatar tallys commented on June 12, 2024 1

@mperrotti do you have availability to take this on?

from components.

mperrotti avatar mperrotti commented on June 12, 2024 1

Button with variant=inivisble has the same foreground color as variant=outline and no disabled state

@mattcosta7 - I see a disabled state on when testing <Button variant="invisible" disabled>Test</Button>. The only inconsistency I'm seeing is the foreground color.

Here's the PR: #3368

from components.

mattcosta7 avatar mattcosta7 commented on June 12, 2024 1

Button with variant=inivisble has the same foreground color as variant=outline and no disabled state

@mattcosta7 - I see a disabled state on when testing <Button variant="invisible" disabled>Test</Button>. The only inconsistency I'm seeing is the foreground color.

Here's the PR: #3368

That sounds about right

from components.

lesliecdubs avatar lesliecdubs commented on June 12, 2024

@tallys do you want to see if a designer is available to take a look at this?

from components.

langermank avatar langermank commented on June 12, 2024

@mperrotti we may need to open this up to a larger discussion about the invisible variant, but the idea is that the foreground color is only link blue for Button if there are no visuals present as demonstrated here. And IconButton is never link blue. There was recent discussion in Slack about this too.

outline variant is being deprecated, and then there's the link variant which is also confusing. Long long ago I proposed making the API overly verbose for buttons styled as links to better differentiate between the invisible variant and a link variant.

Anyways, should we open a discussion? Still worth fixing the disabled state mentioned in this issue.

from components.

mperrotti avatar mperrotti commented on June 12, 2024

Yes @langermank - fully agree that we should open a discussion. Would you like to start the discussion? or should I?

from components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.