Giter Site home page Giter Site logo

Comments (7)

joshblack avatar joshblack commented on June 12, 2024 1

Hey @lesliecdubs! No plans in particular, just was something that came up in PR reviews last week. Inbox triage could be a great place for it 👍

from components.

ollie-iterators avatar ollie-iterators commented on June 12, 2024 1

_VisuallyHidden.tsx is still on the page https://github.com/primer/react/tree/main/src, so it should not be checked off, but _TextInputInnerVisualSlot should be.

from components.

mperrotti avatar mperrotti commented on June 12, 2024 1

We shouldn't have two - we should just have one.

@joshblack - does your VisuallyHidden do anything that the original doesn't?

from components.

ollie-iterators avatar ollie-iterators commented on June 12, 2024 1

It looks like the same thing also may be happening with _TextInputInnerAction.tsx

from components.

lesliecdubs avatar lesliecdubs commented on June 12, 2024

Thanks for filing @joshblack! Should this issue go into our Primer teams backlog "inbox" for triage by the team, or did you have other plans for it?

from components.

green6erry avatar green6erry commented on June 12, 2024

It appears there are two VisuallyHidden components. It looks like the main authors were @mperrotti on the one not in internal, and @joshblack for the one already in internal. The easiest way forward would be to keep both and they are used in multiple places. Is someone able to weigh in how to proceed?

from components.

joshblack avatar joshblack commented on June 12, 2024

@mperrotti I think they have a difference in API and styles and we just haven't taken the time to merge them yet. I think the difference at that point ends up being that you would toggle rendering VisuallyHidden instead of passing in isVisible, if I remember right!

from components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.