Comments (7)
Hey @lesliecdubs! No plans in particular, just was something that came up in PR reviews last week. Inbox triage could be a great place for it 👍
from components.
_VisuallyHidden.tsx is still on the page https://github.com/primer/react/tree/main/src, so it should not be checked off, but _TextInputInnerVisualSlot should be.
from components.
We shouldn't have two - we should just have one.
@joshblack - does your VisuallyHidden
do anything that the original doesn't?
from components.
It looks like the same thing also may be happening with _TextInputInnerAction.tsx
from components.
Thanks for filing @joshblack! Should this issue go into our Primer teams backlog "inbox" for triage by the team, or did you have other plans for it?
from components.
It appears there are two VisuallyHidden
components. It looks like the main authors were @mperrotti on the one not in internal
, and @joshblack for the one already in internal
. The easiest way forward would be to keep both and they are used in multiple places. Is someone able to weigh in how to proceed?
from components.
@mperrotti I think they have a difference in API and styles and we just haven't taken the time to merge them yet. I think the difference at that point ends up being that you would toggle rendering VisuallyHidden
instead of passing in isVisible
, if I remember right!
from components.
Related Issues (20)
- Tests: Remove redundant ThemeProvider from tests
- `DialogV2` has incorrect names for width values HOT 1
- Enhancement: Add support for flush action lists HOT 2
- Update docs for `Button` to not consider `count` as required HOT 1
- Release Tracking
- Using `TooltipV2` always sets aria associations on first child element HOT 11
- [Tests] Ensure that axe calls are made on open state of the component HOT 4
- [TreeView] Add area for `dragHandle` to be shown before the expand/collapse toggle HOT 1
- Release Tracking
- `Stack` `justify` prop has no effect HOT 4
- SelectPanel2 Optimization: Do not add and remove keydown listener for escape key on every render HOT 1
- `Stack` `gap` is overridden on wider layouts
- Release Tracking
- Portal Hardcoded Z-Index Buries Components HOT 2
- Consider modern `moduleResolution`
- Data Table Pagination - when the page numbers in the 1000s the page numbers are unreadable HOT 1
- Dockerize The entire application HOT 1
- [ActionMenu.Button] onClick doesn't function HOT 8
- "npm run setup" doesn't exist in your package.json HOT 1
- Inline `ActionList.Description` can result in horizontal overflow
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from components.