Giter Site home page Giter Site logo

Tidy up and dry up code about primer.style HOT 2 CLOSED

primer avatar primer commented on May 22, 2024
Tidy up and dry up code

from primer.style.

Comments (2)

emplums avatar emplums commented on May 22, 2024

@broccolini I started working on replacing some of the extended Link components with plain Link components since we've now got typography system props in primer/components and a few other Link bugs worked out... one thing I ran into was not being able to access all of our typography theme values (such as mono from fonts, to be used with the styled-system fontFamily props).

What do you think about using the primer/components theme in primer.style instead of what we've got in primer.style now (a few imports from primitives + the default theme values from styled system)? I think it makes sense to build this site with the theme we're shipping with primer/components but not sure if there's any reason in particular that you stuck with imports from primitives? The only hitch I'm seeing is that we'll need to rework a bunch of the spacing since the default breakpoints + spacing values from styled-system are pretty different from our values shipped with primer/components. Let me know what you think!

from primer.style.

broccolini avatar broccolini commented on May 22, 2024

This is now outdated.

from primer.style.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.