Giter Site home page Giter Site logo

Type checking is too slow about react HOT 3 OPEN

keithamus avatar keithamus commented on April 28, 2024 1
Type checking is too slow

from react.

Comments (3)

iansan5653 avatar iansan5653 commented on April 28, 2024 1

As another data point, I see similarly long times in Codespaces:

$ time (npm run type-check -w @primer/react >> dev/null)

real    0m22.054s
user    0m34.194s
sys     0m1.221s

That said, I haven't noticed issues with the VSCode extension; incremental checking in that form seems to work pretty quickly.

We are talking about over 85k lines of TypeScript -- I'd be interested in knowing what 'typical' tsc performance looks like to see if/how bad our code really is, vs just the typechecker not being that fast in general. (Although even if we're seeing typical times, there's still no reason not to try and get some performance gains if it's not too much effort and doesn't require sacrificing code quality)

from react.

siddharthkp avatar siddharthkp commented on April 28, 2024

That's surprisingly long! Do you get instant feedback in your editor or do you have to wait more than 1-2 seconds for that as well?

from react.

joshblack avatar joshblack commented on April 28, 2024

Definitely all for improving performance 👍 Would be great to know what's the floor performance-wise for a project this size along with what the effort would be to get there 👀 When it comes to simplifying types, another possible benefit for this could be improved docgen on the storybook side if they're easier to infer which would be great.

Random, is it possible to profile the project and see which files or types are contributing the most to the check phase?

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.