Comments (2)
prince-chrismc
commented on June 10, 2024
https://api.github.com/repos/conan-io/conan-center-index/pulls/15943/comments
[
{
"url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/1107806852",
"pull_request_review_id": 1300470995,
"id": 1107806852,
"node_id": "PRRC_kwDODDMJAM5CB8qE",
"diff_hunk": "@@ -1,11 +1,8 @@\n-cmake_minimum_required(VERSION 3.8)\n-project(test_package LANGUAGES CXX)\n+cmake_minimum_required(VERSION 3.1)",
"path": "recipes/gemmlowp/all/test_v1_package/CMakeLists.txt",
"commit_id": "e30be3e1d21747ec08081a9910da8178915d2bd5",
"original_commit_id": "e30be3e1d21747ec08081a9910da8178915d2bd5",
"user": {
"login": "Turhsus",
"id": 19829198,
"node_id": "MDQ6VXNlcjE5ODI5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/19829198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Turhsus",
"html_url": "https://github.com/Turhsus",
"followers_url": "https://api.github.com/users/Turhsus/followers",
"following_url": "https://api.github.com/users/Turhsus/following{/other_user}",
"gists_url": "https://api.github.com/users/Turhsus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Turhsus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Turhsus/subscriptions",
"organizations_url": "https://api.github.com/users/Turhsus/orgs",
"repos_url": "https://api.github.com/users/Turhsus/repos",
"events_url": "https://api.github.com/users/Turhsus/events{/privacy}",
"received_events_url": "https://api.github.com/users/Turhsus/received_events",
"type": "User",
"site_admin": false
},
"body": "Why decrease the minimum required version here?",
"created_at": "2023-02-15T22:40:45Z",
"updated_at": "2023-02-15T22:40:46Z",
"html_url": "https://github.com/conan-io/conan-center-index/pull/15943#discussion_r1107806852",
"pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/15943",
"author_association": "NONE",
"_links": {
"self": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/1107806852"
},
"html": {
"href": "https://github.com/conan-io/conan-center-index/pull/15943#discussion_r1107806852"
},
"pull_request": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/15943"
}
},
"reactions": {
"url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/1107806852/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"start_line": null,
"original_start_line": null,
"start_side": null,
"line": 1,
"original_line": 1,
"side": "RIGHT",
"original_position": 3,
"position": 3,
"subject_type": "line"
},
{
"url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/1107835497",
"pull_request_review_id": 1300511850,
"id": 1107835497,
"node_id": "PRRC_kwDODDMJAM5CCDpp",
"diff_hunk": "@@ -1,11 +1,8 @@\n-cmake_minimum_required(VERSION 3.8)\n-project(test_package LANGUAGES CXX)\n+cmake_minimum_required(VERSION 3.1)",
"path": "recipes/gemmlowp/all/test_v1_package/CMakeLists.txt",
"commit_id": "e30be3e1d21747ec08081a9910da8178915d2bd5",
"original_commit_id": "e30be3e1d21747ec08081a9910da8178915d2bd5",
"user": {
"login": "SpaceIm",
"id": 30052553,
"node_id": "MDQ6VXNlcjMwMDUyNTUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30052553?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SpaceIm",
"html_url": "https://github.com/SpaceIm",
"followers_url": "https://api.github.com/users/SpaceIm/followers",
"following_url": "https://api.github.com/users/SpaceIm/following{/other_user}",
"gists_url": "https://api.github.com/users/SpaceIm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SpaceIm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SpaceIm/subscriptions",
"organizations_url": "https://api.github.com/users/SpaceIm/orgs",
"repos_url": "https://api.github.com/users/SpaceIm/repos",
"events_url": "https://api.github.com/users/SpaceIm/events{/privacy}",
"received_events_url": "https://api.github.com/users/SpaceIm/received_events",
"type": "User",
"site_admin": false
},
"body": "It's just a copy/paste of test v1 package templates, it doesn't really matter. This content avoids code duplication. Real CMake logic is in CMakeLists of test package.",
"created_at": "2023-02-15T23:14:15Z",
"updated_at": "2023-02-15T23:15:11Z",
"html_url": "https://github.com/conan-io/conan-center-index/pull/15943#discussion_r1107835497",
"pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/15943",
"author_association": "CONTRIBUTOR",
"_links": {
"self": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/1107835497"
},
"html": {
"href": "https://github.com/conan-io/conan-center-index/pull/15943#discussion_r1107835497"
},
"pull_request": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/15943"
}
},
"reactions": {
"url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/1107835497/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"start_line": null,
"original_start_line": null,
"start_side": null,
"line": 1,
"original_line": 1,
"side": "RIGHT",
"in_reply_to_id": 1107806852,
"original_position": 3,
"position": 3,
"subject_type": "line"
},
{
"url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/1151176378",
"pull_request_review_id": 1361944484,
"id": 1151176378,
"node_id": "PRRC_kwDODDMJAM5EnY66",
"diff_hunk": "@@ -1,11 +1,8 @@\n-cmake_minimum_required(VERSION 3.8)\n-project(test_package LANGUAGES CXX)\n+cmake_minimum_required(VERSION 3.1)",
"path": "recipes/gemmlowp/all/test_v1_package/CMakeLists.txt",
"commit_id": "e30be3e1d21747ec08081a9910da8178915d2bd5",
"original_commit_id": "e30be3e1d21747ec08081a9910da8178915d2bd5",
"user": {
"login": "prince-chrismc",
"id": 16867443,
"node_id": "MDQ6VXNlcjE2ODY3NDQz",
"avatar_url": "https://avatars.githubusercontent.com/u/16867443?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/prince-chrismc",
"html_url": "https://github.com/prince-chrismc",
"followers_url": "https://api.github.com/users/prince-chrismc/followers",
"following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
"gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
"organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
"repos_url": "https://api.github.com/users/prince-chrismc/repos",
"events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
"received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
"type": "User",
"site_admin": false
},
"body": "Conan requires 3.15 regardless :)",
"created_at": "2023-03-28T21:37:56Z",
"updated_at": "2023-03-28T21:37:57Z",
"html_url": "https://github.com/conan-io/conan-center-index/pull/15943#discussion_r1151176378",
"pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/15943",
"author_association": "CONTRIBUTOR",
"_links": {
"self": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/1151176378"
},
"html": {
"href": "https://github.com/conan-io/conan-center-index/pull/15943#discussion_r1151176378"
},
"pull_request": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/15943"
}
},
"reactions": {
"url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/1151176378/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"start_line": null,
"original_start_line": null,
"start_side": null,
"line": 1,
"original_line": 1,
"side": "RIGHT",
"in_reply_to_id": 1107806852,
"original_position": 3,
"position": 3,
"subject_type": "line"
}
]from conan-center-index-pending-review.
prince-chrismc
commented on June 10, 2024
This apparently is not doable in v3 API https://stackoverflow.com/a/55714341
from conan-center-index-pending-review.
Related Issues (20)
- New applet for "interested reviewers" to tag followers of certain recipes HOT 1
- Adjust effort ranking HOT 2
- Handling dismissed approvals
- Valid PR changing github config are rejected
- Approving then commenting does not dismiss approval
- Highlight PRs waiting for just one more review HOT 1
- Green PRs with dismissed or zero Approvals don't appear on the board HOT 2
- Show PRs that are in progress
- Highlight PRs that have merge conflicts HOT 1
- Open Versus Merge fails to upload GIF larger than 1MB
- Open Versus Merged fails to fetch data at the start of a new week
- Support new `bump dependencies` label HOT 1
- Support `GitHub config` labels
- Some PRs are showing new "in progress" when API is sucessful HOT 1
- bot stuck HOT 5
- use upstream information directly HOT 2
- Clean up label detection code
- publish to github pages
- Should labels be transparent?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from conan-center-index-pending-review.