Giter Site home page Giter Site logo

Comments (1)

liushuai839 avatar liushuai839 commented on August 16, 2024

Whilst going through your code in order to try and understand your results, I noticed that in your test code you do not use the resulting keep list from the soft_nms algorithm.

However, if I correctly understand the algorithm, it seems that whenever a box score gets below a certain threshold (0.001 by default), it gets removed from the list by swapping it with the last box from the list and decreasing the number of detections N.
At the end of the algorithm, they return a list with indices of valid detections to keep, but since you do not use it to filter the list, this results in some detections showing double, because the algorithm overwrites low scoring detections with another one.

I quickly tested my hypothesis by modifying this line of code:

# Note that since keep is just a list of increasing numbers [0,1,2,3,...]
# you could probable simplify this code by writing top_bboxes[j+1][:len(keep)]
keep = soft_nms(top_bboxes[j + 1], Nt=nms_threshold, method=nms_algorithm)
top_bboxes[j + 1] = top_bboxes[j+1][np.array(keep, dtype=np.int64)]

I tested this code on a single image and it indeed gives a different result, which makes me believe that there seems to be something weird going on. I don't know whether this change makes the results better or worse, but if my analysis is correct, this seems to be a mistake nonetheless.

Hi,guys, I have some questions about the code in your question.and i want to ask you. can you give me your wechat number? Mine is 14704133471.

from cornernet-lite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.