TypeError: Cannot read property 'map' of undefined (on 1.15 version)

[prismarinejs]

TypeError: Cannot read property 'map' of undefined (on 1.15 version)

[uncovery]

any update regarding this? Thanks!!

[rom1504]

What command did you run exactly ?

…

On Wed, May 6, 2020, 08:57 Uncovery ***@***.***> wrote: any update regarding this? Thanks!! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437SUVUSPWDLCZRXWXILRQEC55ANCNFSM4KRKW6RA> .

[uncovery]

node image_names.js 1.15.2 out tmp

I think the issue might be that the 1.15.2 data does not exist (yet)?

[uncovery]

If I run this with 1.14, I get something else (but similar). Under what circumstances is this script supposed to work? Should it at least work for non-issue items and jump over the issues or is it desired behavior that it fails? I don't understand enough of the data structure to be able to say...

/minecraft-jar-extractor/image_names.js:250
    const model = itemMapping[item.name] ? itemMapping[item.name] : item.name
                             ^

TypeError: Cannot read property 'air' of undefined
    at mcData.itemsArray.map.item (/home/minecraft/server/mc_assets/minecraft-jar-extractor/image_names.js:250:30)
    at Array.map (<anonymous>)
    at getItems (/home/minecraft/server/mc_assets/minecraft-jar-extractor/image_names.js:249:42)
    at /home/minecraft/server/mc_assets/minecraft-jar-extractor/image_names.js:302:5
    at /home/minecraft/server/mc_assets/minecraft-jar-extractor/get_minecraft_files.js:19:7
    at ZipFile.<anonymous> (/home/minecraft/server/mc_assets/minecraft-jar-extractor/node_modules/extract-zip/index.js:46:11)
    at ZipFile.emit (events.js:198:13)
    at FdSlicer.<anonymous> (/home/minecraft/server/mc_assets/minecraft-jar-extractor/node_modules/yauzl/index.js:202:10)
    at Object.onceWrapper (events.js:286:20)
    at FdSlicer.emit (events.js:198:13)
    at onCloseDone (/home/minecraft/server/mc_assets/minecraft-jar-extractor/node_modules/fd-slicer/index.js:74:12)
    at /home/minecraft/server/mc_assets/minecraft-jar-extractor/node_modules/graceful-fs/graceful-fs.js:61:14
    at FSReqWrap.args [as oncomplete] (fs.js:140:20)

[rom1504]

Didn't have time yet, but what I would do, and what you can do too is looking at the code and making it work for recent versions. As explained Mojang changes stuff every version, so these scripts often need adapting.

…

On Fri, May 8, 2020, 06:56 Uncovery ***@***.***> wrote: If I run this with 1.14, I get something else (but similar). Under what circumstances is this script supposed to work? Should it at least work for non-issue items and jump over the issues or is it desired behavior that it fails? I don't understand enough of the data structure to be able to say... /minecraft-jar-extractor/image_names.js:250 const model = itemMapping[item.name] ? itemMapping[item.name] : item.name ^ TypeError: Cannot read property 'air' of undefined at mcData.itemsArray.map.item (/home/minecraft/server/mc_assets/minecraft-jar-extractor/image_names.js:250:30) at Array.map (<anonymous>) at getItems (/home/minecraft/server/mc_assets/minecraft-jar-extractor/image_names.js:249:42) at /home/minecraft/server/mc_assets/minecraft-jar-extractor/image_names.js:302:5 at /home/minecraft/server/mc_assets/minecraft-jar-extractor/get_minecraft_files.js:19:7 at ZipFile.<anonymous> (/home/minecraft/server/mc_assets/minecraft-jar-extractor/node_modules/extract-zip/index.js:46:11) at ZipFile.emit (events.js:198:13) at FdSlicer.<anonymous> (/home/minecraft/server/mc_assets/minecraft-jar-extractor/node_modules/yauzl/index.js:202:10) at Object.onceWrapper (events.js:286:20) at FdSlicer.emit (events.js:198:13) at onCloseDone (/home/minecraft/server/mc_assets/minecraft-jar-extractor/node_modules/fd-slicer/index.js:74:12) at /home/minecraft/server/mc_assets/minecraft-jar-extractor/node_modules/graceful-fs/graceful-fs.js:61:14 at FSReqWrap.args [as oncomplete] (fs.js:140:20) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437XVJYFKQMN7AU4ITZTRQOGHXANCNFSM4KRKW6RA> .

[uncovery]

This seems to be fixed now, seems you have fixed it.

I am sorry, but I am not able to debug this properly since I fail to understand the script and the underlying modules.

[rom1504]

It's fixed yes