Significant perf regression in version 2.21.0 with Webpack v4

[Chevelleboyer]

Significant perf regression in version 2.21.0 with Webpack v4

[Chevelleboyer]

Yes that's correct, even with devtools: false it seems like asset.source.sourceAndMap() is still being called. Our patch just calls asset.source.source() instead of asset.source.sourceAndMap() if sourcemaps aren't enabled.

And yes I'm happy to open a PR!😄

[privatenumber]

I can't help you with how little information you've provided.

Can you provide a minimal reproduction so I can debug?

[Chevelleboyer]

You mean n/a wasn't enough? 😂

While trying to reproduce with a trivial project, I found that we actually had a patch for esbuild-loader 2.20.0

Our patch was disabling the calls to asset.source.map() and asset.source.sourceAndMap() unless it was a sourcemap build. (We generate sourcemaps in a separate build)

Removing our patch makes v2.20.0 and v2.21.0 perform the same 😃

Closing this now, sorry for any troubles!!

[privatenumber]

Are you saying disabling those calls makes large performance improvements even with devtools: false in the Webpack config?

If so, I'm very open to bringing those changes into the project. Would you be willing to open a PR?