windows, cmsisdap: incorrect "Probe was not found" error if wrong driver bound with zadig.

[Dirbaio]

windows, cmsisdap: incorrect "Probe was not found" error if wrong driver bound with zadig.

[kevinmehall]

This would be detected by an error returned by claim_interface. probe-rs is currently silently ignoring errors from that call, but by that point you've decided that it's the interface you want, so you should probably display a message if claiming it fails instead of saying "Probe was not found".

probe-rs/probe-rs/src/probe/cmsisdap/tools.rs

Lines 204 to 216 in 6b60cdb

	// Attempt to claim this interface
	match device.claim_interface(interface.interface_number()) {
	Ok(handle) => {
	tracing::debug!("Opening {:04x}:{:04x} in CMSIS-DAPv2 mode", vid, pid);
	return Some(CmsisDapDevice::V2 {
	handle,
	out_ep: eps[0].address(),
	in_ep: eps[1].address(),
	swo_ep,
	max_packet_size: eps[1].max_packet_size(),
	});
	}
	Err(_) => continue,

kevinmehall/nusb#41 makes the error from claim_interface more specific in this case. ErrorKind::Unsupported roughly maps to "You should use Zadig to bind WinUSB".

Claiming an interface would also fail if another process has it claimed -- ErrorKind::ResourceBusy on Linux and macOS, currently ErrorKind::PermissionDenied on Windows, not sure we can tell it apart from a permissions issue.

[rgrr]

Solution could be to not use a probe requiring Zadig. Zadig has TMO too many compatibility issues.

Question: does the most recent picoprobe still require Zadig? If yes, I'ld suggest https://github.com/rgrr/yapicoprobe ;-)

[Dirbaio]

the upstream picoprobe includes the winusb descriptors so it works out of the box on Windows without having to use zadig.

In this particular case, the person who ran into this issue had used zadig anyway for some reason (probably troubleshoot another issue), replacing the default (correct) winusb drivers with something else.

[rgrr]

Thanks for clarification.

I saw the keyword "Zadig" which creates immediate rash on my side. Now that I have read the last sentence of the description I understand the issue. I'ld write some kind of configuration FAQ. But perhaps not a bad idea to implement this FAQ in code if the problem is clearly detectable.

[Dirbaio]

exactly. this issue is about "probe-rs says probe not found, but it should say probe found but you installed the wrong driver with zadig, please use zadig again to install winusb"