Comments (3)
The value for edgeSight is 0.49597, just below the threshold of 0.5 to get a front facade. Its way-segment has a lot of quite near facades, which makes its average distance low. Maybe we leave this threshold for a moment and collect other examples before we screw at this parameter.
from blosm.
Another example is just across the street from the back facade in the first message. Both side and back facades should be classified as the front ones.
from blosm.
Another example is just across the street from the back facade in the first message. Both side and back facades should be classified as the front ones.
These two facades are not classified as front facades due to the angle weight in edgeSight computation, similar to corner facades (see issue #14). But here we can't use similar considerations. We could try to relax the angle restriction by extending the angle weight and allow a broader range of angles. For instance the weight could be set to one until 45° and to start the restriction there (red line):
But then, many other facades also get classified as front facades, for instance in bern_old_town.osm the facades pointed to by cyan arrows in the follwing image:
Such changes are delicate. You may try yourself and see whether you agree with the result by replacing the line 50 in facade_classification.py by the follwoing three lines:
pseudoAngle = visInfo.dx/(visInfo.dx+visInfo.dy) * 2.
angleWeight = pseudoAngle if pseudoAngle < 1. else 1.
edgeSight = visInfo.value * angleWeight * visInfo.waySegment.avgDist/visInfo.distance
from blosm.
Related Issues (20)
- Modify iterable while iteration HOT 1
- Inconsistent data in an instance of Street HOT 3
- Additional data for the street renderer HOT 1
- [question] How to configure which OSM-ways are processed HOT 1
- Experiments around clustering of intersections HOT 5
- Inconsistency in the returned data (berlin_karl_marx_allee.osm) HOT 6
- Street sections with an offset don't fit intersections HOT 2
- A problem with a style block assignment HOT 5
- Splitting a section HOT 18
- Question: Are the attributes succ and pred already set by the call of street.setStyleForItems(streetStyle)? HOT 6
- Question: pred-succ vs incoming-outgoing in the class SideLane HOT 4
- Omitting the intersection connectors HOT 8
- Sections don't fit each other after applying the offset HOT 4
- A code for the intersection point of 2 line segments HOT 4
- Weird polylines HOT 2
- A change in the data structure for intersections HOT 2
- street.pred is None and street.succ is None for street.id == 503 HOT 2
- T-shape intersections HOT 9
- Enabling Bundles and intersections with Bundles, produced in StreetGenerator HOT 31
- item.street was not updated after the street extension HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blosm.